refactor(behavior_path_planner): use function with color name #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
satoshi-ota
reviewed
Aug 29, 2023
planning/behavior_path_planner/include/behavior_path_planner/marker_utils/colors.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…arker_utils/colors.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
6f76306 to
0dd15e4
Compare
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Aug 30, 2023
…refoundation#4797) * refactor(behavior_path_planner): use function with color name Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_planner/include/behavior_path_planner/marker_utils/colors.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
kyoichi-sugahara
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
…refoundation#4797) * refactor(behavior_path_planner): use function with color name Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_planner/include/behavior_path_planner/marker_utils/colors.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
kyoichi-sugahara
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 12, 2023
zulfaqar-azmi-t4
added a commit
to tier4/autoware.universe
that referenced
this pull request
Sep 14, 2023
…refoundation#4797) * refactor(behavior_path_planner): use function with color name Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Update planning/behavior_path_planner/include/behavior_path_planner/marker_utils/colors.hpp Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 0dd15e4
This pull request refactors the code for specifying colors for markers in the
behavior_path_plannerpackage. It introduces a new header filecolors.hppthat defines color utility functions, and updates thedebug.cppsource file to use them. It also removes the redundantcolorsListfunction from theutils.hppheader file. The purpose of these changes is to simplify and standardize the color usage for lane change visualization and debugging.Required #4796 to be merged.
Tests performed
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.