refactor(initial_pose_button_panel): delete intial_pose_button_panel #4519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yamato-ando <Yamato ANDO>
|
@YamatoAndo Could you let me know how to confirm this deletion? Is it needed to get any GUI before/after images? |
|
@Motsu-san
|
|
LGTM beforeThe panel option existed AfterThe panel option disappeared |
Motsu-san
approved these changes
Aug 10, 2023
LeoDriveProject
pushed a commit
to leo-drive/autoware.universe.golf
that referenced
this pull request
Aug 16, 2023
…utowarefoundation#4519) Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Aug 21, 2023
…utowarefoundation#4519) Signed-off-by: yamato-ando <Yamato ANDO> Co-authored-by: yamato-ando <Yamato ANDO>
3 tasks
This was referenced Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The functionality has been ported to
tier4_state_rviz_plugin, so theinitial_pose_button_panelwill be removed as it is no longer needed.Related links
The PR for porting the functionality #4392
Tests performed
only check CI/CD
Notes for reviewers
N/A
Interface changes
N/A
Effects on system behavior
N/A
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.