Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_state_rviz_plugin): add init by gnss button #4392

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Jul 25, 2023

Description

Add a button to initialize localization by GNSS to the state panel.
image
When this button is clicked, /api/localization/initialize service is called with no arguments.
Calling /api/localization/initialize with no arguments means that gnss pose is used for pose initialization.

auto pose = req->pose.empty() ? get_gnss_pose() : req->pose.front();

Related Links

TIER IV INTERNAL LINK

Tests performed

Check that the pose is initialized when the button is pushed in the logging simulation without automatic_pose_initializer.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi requested a review from h-ohta as a code owner July 25, 2023 23:41
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jul 25, 2023
@isamu-takagi isamu-takagi self-assigned this Jul 25, 2023
@isamu-takagi isamu-takagi enabled auto-merge (squash) July 25, 2023 23:44
@YamatoAndo
Copy link
Contributor

I have confirmed that it works 👍

@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 3, 2023
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (6768a29) 14.88% compared to head (933da9a) 14.88%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4392      +/-   ##
==========================================
- Coverage   14.88%   14.88%   -0.01%     
==========================================
  Files        1520     1520              
  Lines      104953   104959       +6     
  Branches    31977    31977              
==========================================
  Hits        15624    15624              
- Misses      72261    72267       +6     
  Partials    17068    17068              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.88% <ø> (+<0.01%) ⬆️ Carriedforward from 6768a29

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...er4_state_rviz_plugin/src/autoware_state_panel.cpp 0.00% <0.00%> (ø)
...er4_state_rviz_plugin/src/autoware_state_panel.hpp 0.00% <ø> (ø)
..._merger/include/object_association_merger/node.hpp 0.00% <ø> (ø)
...ject_merger/src/object_association_merger/node.cpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit 1f873b0 into autowarefoundation:main Aug 3, 2023
@isamu-takagi isamu-takagi deleted the feat/state-panel-init-by-gnss-button branch August 3, 2023 07:42
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants