-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rviz config): remove initial_pose_button_panel #4959
fix(rviz config): remove initial_pose_button_panel #4959
Conversation
Signed-off-by: yamato-ando <Yamato ANDO>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4959 +/- ##
==========================================
- Coverage 15.80% 15.67% -0.14%
==========================================
Files 1580 1607 +27
Lines 109179 110114 +935
Branches 33646 33646
==========================================
Hits 17258 17258
- Misses 73313 74248 +935
Partials 18608 18608
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@yukke42 @knzo25 Please review this PR about @tkimura4 @taikitanaka3 @1222-takeshi Please review this PR about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
#4848
rviz reports the following error:
This plugin was removed #4519.
So I will also remove tier4_localization_rviz_plugin/InitialPoseButtonPanel from the rviz cofings.
Tests performed
I have confirmed that no errors occur when launching RViz with each rviz config file.
like this.
ros2 run rviz2 rviz2 -d src/universe/autoware.universe/planning/obstacle_avoidance_planner/rviz/obstacle_avoidance_planner.rviz
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.