Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching #4048

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 22, 2023

Description

suppress the chattering dynamic avoidance to launch

Tests performed

planning simulator

Effects on system behavior

Stabler dynamic avoidance

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 22, 2023
@takayuki5168 takayuki5168 changed the title feat(dynamic_avoidance): successive num condition to entry feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching Jun 22, 2023
@takayuki5168 takayuki5168 force-pushed the feat/dynamic-avoidance-not-flickering-entry branch from b5e8905 to 186b5d9 Compare June 22, 2023 15:41
@takayuki5168 takayuki5168 marked this pull request as ready for review June 22, 2023 15:41
…nching

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/dynamic-avoidance-not-flickering-entry branch from ef92c3e to 0867da2 Compare June 23, 2023 06:28
@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.28 🎉

Comparison is base (3b162aa) 14.31% compared to head (0867da2) 14.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4048      +/-   ##
==========================================
+ Coverage   14.31%   14.60%   +0.28%     
==========================================
  Files        1557     1570      +13     
  Lines      106900   107773     +873     
  Branches    30777    31319     +542     
==========================================
+ Hits        15302    15736     +434     
- Misses      75028    75070      +42     
- Partials    16570    16967     +397     
Flag Coverage Δ *Carryforward flag
differential 13.50% <0.00%> (?)
total 14.31% <ø> (+<0.01%) ⬆️ Carriedforward from 3b162aa

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...id_map/laserscan_based_occupancy_grid_map_node.hpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.hpp ∅ <ø> (∅)
...e/updater/occupancy_grid_map_updater_interface.hpp 0.00% <ø> (ø)
...id_map/laserscan_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <ø> (ø)
...occupancy_grid_map_binary_bayes_filter_updater.cpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 17.54% <0.00%> (-0.79%) ⬇️
...er/src/scene_module/avoidance/avoidance_module.cpp 13.16% <0.00%> (+9.02%) ⬆️
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
... and 2 more

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit a0a0b1a into autowarefoundation:main Jun 23, 2023
@takayuki5168 takayuki5168 deleted the feat/dynamic-avoidance-not-flickering-entry branch June 23, 2023 07:48
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jun 23, 2023
…nching (autowarefoundation#4048)

* feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
…nching (autowarefoundation#4048)

* feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
* feat(dynamic_avoidance): apply LPF to shift length, and positive relative velocity (autowarefoundation#4047)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching (autowarefoundation#4048)

* feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(dynamic_avoidance): ignore cut-out vehicle

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update cut out decision policy

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(obstacle_avoidance_planner): smooth path connection after optimization (autowarefoundation#3754)

* fix(obstacle_avoidance_planner): smooth path connection after optimization

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(obstacle_avoidance_planner): fix optimization constraint for narrow-road driving (autowarefoundation#3701)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(lane_change): copy drivable area info (autowarefoundation#3738)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(map_based_prediction): suppress lane change decision flickering (autowarefoundation#3788)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(map_based_prediction): disable time delay compensation (autowarefoundation#3806)

* disable time delay compensation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix unused parameter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix lane change decision not working problem due to empty future_lanenet in unconnected lanelets

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix(behavior_path_planner): boundary's nearest search (autowarefoundation#3716)

* fix(behavior_path_planner): boundary's nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(behavior_path_planner): extract backward obstacles correctly (autowarefoundation#3719)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(behavior_path_planner): extract obstacles from drivable area without intersection (autowarefoundation#3741)

* fix(behavior_path_planner): extract obstacles from drivable area without intersection

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update map_based_prediction method

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(avoidance): fix invalid cherry pick

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants