-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(obstacle_avoidance_planner): fix optimization constraint for narrow-road driving #3701
Merged
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:fix/narrow-road-driving-constraint
May 14, 2023
Merged
fix(obstacle_avoidance_planner): fix optimization constraint for narrow-road driving #3701
takayuki5168
merged 1 commit into
autowarefoundation:main
from
tier4:fix/narrow-road-driving-constraint
May 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow-road driving Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3701 +/- ##
=======================================
Coverage 14.56% 14.56%
=======================================
Files 1409 1409
Lines 99290 99290
Branches 29347 29347
=======================================
Hits 14458 14458
Misses 69247 69247
Partials 15585 15585
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
kosuke55
approved these changes
May 14, 2023
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 16, 2023
…ow-road driving (autowarefoundation#3701) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
j4tfwm6z
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
May 25, 2023
…ow-road driving (autowarefoundation#3701) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
j4tfwm6z
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 22, 2023
…ow-road driving (autowarefoundation#3701) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 23, 2023
…ow-road driving (autowarefoundation#3701) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 26, 2023
…ow-road driving (autowarefoundation#3701) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 26, 2023
* feat(dynamic_avoidance): apply LPF to shift length, and positive relative velocity (autowarefoundation#4047) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching (autowarefoundation#4048) * feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update config Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(dynamic_avoidance): ignore cut-out vehicle Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update cut out decision policy Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(obstacle_avoidance_planner): smooth path connection after optimization (autowarefoundation#3754) * fix(obstacle_avoidance_planner): smooth path connection after optimization Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(obstacle_avoidance_planner): fix optimization constraint for narrow-road driving (autowarefoundation#3701) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(lane_change): copy drivable area info (autowarefoundation#3738) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(map_based_prediction): suppress lane change decision flickering (autowarefoundation#3788) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(map_based_prediction): disable time delay compensation (autowarefoundation#3806) * disable time delay compensation Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix unused parameter Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix lane change decision not working problem due to empty future_lanenet in unconnected lanelets Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix(behavior_path_planner): boundary's nearest search (autowarefoundation#3716) * fix(behavior_path_planner): boundary's nearest search Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(behavior_path_planner): extract backward obstacles correctly (autowarefoundation#3719) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(behavior_path_planner): extract obstacles from drivable area without intersection (autowarefoundation#3741) * fix(behavior_path_planner): extract obstacles from drivable area without intersection Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update map_based_prediction method Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix(avoidance): fix invalid cherry pick Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com> Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
takayuki5168
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 29, 2023
…ow-road driving (autowarefoundation#3701) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic to modify the optimization constraint in the case where the drivable area's width is smaller than the vehicle's width (e.g. dynamic obstacle is extracted from the drivable area) is wrong.
Tests performed
planning simulator
Effects on system behavior
Optimization will become easier to be solved in the case where the drivable area's width is smaller than the vehicle's width (e.g. dynamic obstacle is extracted from the drivable area)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.