Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): fix optimization constraint for narrow-road driving #3701

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 13, 2023

Description

The logic to modify the optimization constraint in the case where the drivable area's width is smaller than the vehicle's width (e.g. dynamic obstacle is extracted from the drivable area) is wrong.

Tests performed

planning simulator

Effects on system behavior

Optimization will become easier to be solved in the case where the drivable area's width is smaller than the vehicle's width (e.g. dynamic obstacle is extracted from the drivable area)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ow-road driving

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 13, 2023
@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5e5c4dd) 14.56% compared to head (9485d30) 14.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3701   +/-   ##
=======================================
  Coverage   14.56%   14.56%           
=======================================
  Files        1409     1409           
  Lines       99290    99290           
  Branches    29347    29347           
=======================================
  Hits        14458    14458           
  Misses      69247    69247           
  Partials    15585    15585           
Flag Coverage Δ *Carryforward flag
differential 40.69% <0.00%> (?)
total 14.56% <ø> (+<0.01%) ⬆️ Carriedforward from 5e5c4dd

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...g/obstacle_avoidance_planner/src/mpt_optimizer.cpp 40.51% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 marked this pull request as ready for review May 14, 2023 11:08
@takayuki5168 takayuki5168 requested review from kosuke55, TakaHoribe and a team as code owners May 14, 2023 11:08
@takayuki5168 takayuki5168 merged commit ee788c2 into autowarefoundation:main May 14, 2023
@takayuki5168 takayuki5168 deleted the fix/narrow-road-driving-constraint branch May 14, 2023 11:12
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request May 16, 2023
…ow-road driving (autowarefoundation#3701)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
j4tfwm6z pushed a commit to tier4/autoware.universe that referenced this pull request May 25, 2023
…ow-road driving (autowarefoundation#3701)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
j4tfwm6z pushed a commit to tier4/autoware.universe that referenced this pull request Jun 22, 2023
…ow-road driving (autowarefoundation#3701)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jun 23, 2023
…ow-road driving (autowarefoundation#3701)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
…ow-road driving (autowarefoundation#3701)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Jun 26, 2023
* feat(dynamic_avoidance): apply LPF to shift length, and positive relative velocity (autowarefoundation#4047)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching (autowarefoundation#4048)

* feat(dynamic_avoidance): suppress flickering of dynamic avoidance launching

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update config

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(dynamic_avoidance): ignore cut-out vehicle

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update cut out decision policy

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(obstacle_avoidance_planner): smooth path connection after optimization (autowarefoundation#3754)

* fix(obstacle_avoidance_planner): smooth path connection after optimization

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(obstacle_avoidance_planner): fix optimization constraint for narrow-road driving (autowarefoundation#3701)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(lane_change): copy drivable area info (autowarefoundation#3738)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(map_based_prediction): suppress lane change decision flickering (autowarefoundation#3788)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* feat(map_based_prediction): disable time delay compensation (autowarefoundation#3806)

* disable time delay compensation

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix unused parameter

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix lane change decision not working problem due to empty future_lanenet in unconnected lanelets

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

---------

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>

* fix(behavior_path_planner): boundary's nearest search (autowarefoundation#3716)

* fix(behavior_path_planner): boundary's nearest search

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(behavior_path_planner): extract backward obstacles correctly (autowarefoundation#3719)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(behavior_path_planner): extract obstacles from drivable area without intersection (autowarefoundation#3741)

* fix(behavior_path_planner): extract obstacles from drivable area without intersection

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update map_based_prediction method

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* fix(avoidance): fix invalid cherry pick

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: satoshi-ota <satoshi.ota928@gmail.com>
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request Jun 29, 2023
…ow-road driving (autowarefoundation#3701)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants