feat: add vector map requirements #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsudome-r
reviewed
Jul 2, 2024
docs/design/autoware-architecture/map/map-requirements/assets/vm-07-03.svg
Outdated
Show resolved
Hide resolved
docs/design/autoware-architecture/map/map-requirements/overview.md
Outdated
Show resolved
Hide resolved
…/autoware-documentation into vector-maprequirement-proposal
yukkysaito
reviewed
Jul 3, 2024
.../design/autoware-architecture/map/map-requirements/vector-map-requirements-overview/index.md
Outdated
Show resolved
Hide resolved
|
LGTM |
mitsudome-r
approved these changes
Jul 5, 2024
|
@nisshan-x LGTM, but the PR seems to be failing in the CI for DCO check. When you push commits, could you push with signed-off commits? For example by running the following command: |
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
…cker-installation.md" (autowarefoundation#571) Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
…pport (autowarefoundation#578) Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai> Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp> Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Signed-off-by: Md. Muhaimin Rahman <sezan92@gmail.com> Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
* Update Fixposition docs Signed-off-by: Fixposition Support <github@fixposition.com> * Ignore spell checker Signed-off-by: Fixposition Support <github@fixposition.com> --------- Signed-off-by: Fixposition Support <github@fixposition.com> Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com> Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
* fix table Signed-off-by: Go Sakayori <gsakayori@gmail.com> * fix reference implementation links Signed-off-by: Go Sakayori <gsakayori@gmail.com> * style(pre-commit): autofix * fix typo Signed-off-by: Go Sakayori <gsakayori@gmail.com> * fix links Signed-off-by: Go Sakayori <gsakayori@gmail.com> * fix Signed-off-by: Go Sakayori <gsakayori@gmail.com> --------- Signed-off-by: Go Sakayori <gsakayori@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
…/autoware-documentation into vector-maprequirement-proposal
|
@mitsudome-r I fixed DCO failure. Could you merge the pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Vector Map Creation Requirement Specifications.
For the details, please refer to Proposal.
Related links
Proposal Link
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.