Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(support-guidelines): update guidelines for Autoware community support #578

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jun 24, 2024

Description

I've made a lot of improvements on the support-guidelines page of the documentation.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@xmfcx xmfcx requested review from yukkysaito and mitsudome-r June 24, 2024 09:21
@xmfcx xmfcx self-assigned this Jun 24, 2024
@xmfcx xmfcx added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Jun 24, 2024
@yukkysaito
Copy link
Contributor

@xmfcx Thank you for PR 👍

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
@mitsudome-r mitsudome-r changed the title feat(support-guidelines): improve feat(support-guidelines): update Guidelines for Autoware community support Jun 24, 2024
@mitsudome-r mitsudome-r changed the title feat(support-guidelines): update Guidelines for Autoware community support feat(support-guidelines): update guidelines for Autoware community support Jun 24, 2024
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me.
We can merge once https://autowarefoundation.github.io/autoware-documentation/pr-578/support/support-guidelines/ becomes available and the formatting looks okay.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx merged commit 0bcd252 into main Jun 24, 2024
9 checks passed
@xmfcx xmfcx deleted the feat/update-support-guidelines branch June 24, 2024 09:59
nisshan-x pushed a commit to nisshan-x/autoware-documentation that referenced this pull request Jul 5, 2024
…pport (autowarefoundation#578)

Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants