Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Fixposition documentation #566

Merged
merged 3 commits into from
Jun 26, 2024
Merged

docs: update Fixposition documentation #566

merged 3 commits into from
Jun 26, 2024

Conversation

fixposition-support
Copy link
Contributor

@fixposition-support fixposition-support commented Jun 5, 2024

Description

This PR:

  • Fixes the title for Fixposition sensor
  • Adds links to helper utilities

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fixposition Support <github@fixposition.com>
@souryavarenya
Copy link

On behalf of @fixposition-support, unsure why the DCO check is failing. Can the maintainers have a look at this?

@souryavarenya
Copy link

@isamu-takagi @mitsudome-r I'm assuming you're the maintainers here, could you please look into this?

@isamu-takagi
Copy link
Contributor

@souryavarenya @fixposition-support
I don't know why, but the action sometimes doesn't get triggered. If I make any commits it works, so I merged the main branch.

There is an error in the spell check, so please register the word according to this page. In this case, I think it's easier to use cspell:ignore.

Signed-off-by: Fixposition Support <github@fixposition.com>
@fixposition-support
Copy link
Contributor Author

@isamu-takagi Thank you for the response. I now added a spell ignore. Please let me know if I must do anything else.

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isamu-takagi isamu-takagi merged commit 33964a8 into autowarefoundation:main Jun 26, 2024
10 checks passed
@fixposition-support fixposition-support deleted the docs/update-fixposition-docs branch June 26, 2024 13:35
nisshan-x pushed a commit to nisshan-x/autoware-documentation that referenced this pull request Jul 5, 2024
* Update Fixposition docs

Signed-off-by: Fixposition Support <github@fixposition.com>

* Ignore spell checker

Signed-off-by: Fixposition Support <github@fixposition.com>

---------

Signed-off-by: Fixposition Support <github@fixposition.com>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
Signed-off-by: Nishimoto, Shinya <shinya.nishimoto@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants