Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation code for React@16 #1118

Closed
12 tasks done
cncolder opened this issue Apr 10, 2017 · 7 comments
Closed
12 tasks done

Update deprecation code for React@16 #1118

cncolder opened this issue Apr 10, 2017 · 7 comments
Assignees
Milestone

Comments

@cncolder
Copy link
Contributor

cncolder commented Apr 10, 2017

updated by @paranoidjk

react-component/slider#252
ant-design/ant-design#5678
#1171

even upgrade minor version in ~ syntax is unnecessary , still change it expicity in order to check on by one

Version

1.0.8

Environment

web

Reproduction link

https://github.com/facebook/react/releases/tag/v15.5.0

Steps to reproduce

Search React.createClass in ./components

What is expected?

Transform React.createClass to plain JavaScript classes

What is actually happening?

There are 8 results under ./components


React@15.5.0 add two deprecation warning. React.createClass and React.PropTypes. We are lucky bcs we use Typescript to check prop types. But we still have 8 lines React.createClass stay there.

Also need update all react-components dependencies.

Warning: React.createClass is deprecated and will be removed in version 16.
  Use plain JavaScript classes instead.
  If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.
@warmhug
Copy link
Contributor

warmhug commented May 23, 2017

m-select-list / m-pull-to-refresh 现在已经不维护,先可以不用改

@paranoidjk
Copy link
Contributor

@warmhug @silentcloud @pingan1927 这个剩下的各自来认领,尽量 clean 掉。也检查下还有没有漏的

@silentcloud
Copy link
Contributor

好 认领一个 m-picker

@silentcloud
Copy link
Contributor

@silentcloud
Copy link
Contributor

剩下两个,等发布,PR 已提交了

paranoidjk pushed a commit to react-component/m-date-picker that referenced this issue Jun 26, 2017
@paranoidjk
Copy link
Contributor

I think we already fixed this. 😄

lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this issue Apr 26, 2018
Senior-Hayato-Suzuki pushed a commit to Senior-Hayato-Suzuki/react-date-picker that referenced this issue Feb 16, 2020
Senior-Hayato-Suzuki pushed a commit to Senior-Hayato-Suzuki/react-date-picker that referenced this issue Feb 26, 2020
bigpeaches added a commit to bigpeaches/m-date-picker that referenced this issue Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@cncolder @pingan1927 @silentcloud @warmhug @himStone @paranoidjk and others