fix react16 warning, ref https://github.com/ant-design/ant-design-mob… #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ci is broken |
|
我改成 es6 比较好点 |
|
@paranoidjk ci 是 coverage 跑不了，报错 在 master 的 8b760e7 改动里已经挂了，对 jest 不熟，搜了半天解决方法，没搞定，就不在这个 pr 里解决 coverage 的问题了 |
|
我下午来看看ci的问题 |
|
@paranoidjk ci 的问题看了？ |
|
@silentcloud ci 我fix了，你看一下 |
5ba2edc to
d1b0304
Compare
silentcloud
commented
Jun 26, 2017
| @@ -40,7 +40,7 @@ | |||
| }, | |||
| "jest": { | |||
| "collectCoverageFrom": [ | |||
| "src/*" | |||
| "lib/*" | |||
There was a problem hiding this comment.
这样改，覆盖率就不是源码了吧，是不是应该自定义 transform 才对 @paranoidjk
There was a problem hiding this comment.
主要是我现在 test 里面就是引用的 lib
你可以试试改成 test 里面 引用 src，并且加上对应的 jest transform
注意 import '../' 是会应用 lib 的
There was a problem hiding this comment.
先按你这样搞吧，后面有时间再换 src 好了
|
@silentcloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design-mobile#1118