Fix React v15.5.0 new deprecation warnings #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@u9lyfish, thanks for your PR! By analyzing the history of the files in this pull request, we identified @warmhug, @liqi07 and @pingan1927 to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
- Coverage 69.73% 69.72% -0.02%
==========================================
Files 218 218
Lines 4111 4122 +11
Branches 1217 1218 +1
==========================================
+ Hits 2867 2874 +7
- Misses 1243 1247 +4
Partials 1 1
Continue to review full report at Codecov.
|
himStone
reviewed
Apr 19, 2017
|
@bccsafe just ignore codecov sometimes. If you reviewd this PR is ok, them merge it. |
paranoidjk
approved these changes
Apr 20, 2017
12 tasks
lixiaoyang1992
pushed a commit
to lixiaoyang1992/ant-design-mobile
that referenced
this pull request
Apr 26, 2018
* Fix PropTypes deprecation warnings https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html * Fix createClass deprecation warnings https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React v15.5.0 extracted
React.PropTypesandReact.createClassinto their own packages. Usage of these two modules will result in console errors.See: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html
This PR migrates components to new styles according to official guide above.