Fix react16 warning #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
这个谁处理一下？ |
npm owner ls rmc-picker
silentcloud <rjmuqiang@gmail.com>
yiminghe <yiminghe@gmail.com> |
|
报错的问题解决了？ |
|
花了好久时间，没定位到问题，试着将 rc-tools 改成和 antd-tools 一样的配置（ts 版本等）都不行，囧 |
|
那 CI 为什么是过的？ 或者干脆改成 es6 算了。 另外我没有 npm owner 权限 |
|
改成 es6了，改了好多 另：@paranoidjk 给你加 owner 了 |
paranoidjk
reviewed
Jun 8, 2017
| const MultiPicker = React.createClass<MultiPickerProps, any>({ | ||
| mixins: [MultiPickerMixin], | ||
| class MultiPicker extends React.Component<MultiPickerProps, any> { | ||
| getValue: () => any; |
There was a problem hiding this comment.
不定义就会报错，getValue 在 mixin 里
paranoidjk
reviewed
Jun 8, 2017
| @@ -38,11 +40,11 @@ const PopupPicker = React.createClass<IPopupPickerProps, any>({ | |||
| animationType="slide-up" | |||
| wrapStyle={styles.modal} | |||
| visible={this.state.visible} | |||
| onClose={this.onDismiss} | |||
| onClose={this.onDismiss.bind(this)} | |||
There was a problem hiding this comment.
都改成 es6 class, 加上 arrow function，应该不再需要 bind this ?
There was a problem hiding this comment.
@paranoidjk 好多 mixin，不加找不到的，最开始就是没加，发现有问题才加了
There was a problem hiding this comment.
试试 typescript mixin https://www.typescriptlang.org/docs/handbook/mixins.html
There was a problem hiding this comment.
这个 bind 跟 typescript mixin 没啥关系应该，报错的是代码逻辑，不是 ts
There was a problem hiding this comment.
去掉 onDismiss 里的就执行不了，或者有其他方式避免？
|
@silentcloud 你发版本吧。代码以后再优化算了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.