Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #618/cb2b186f backport][stable-2] Update hostname_variable tag override example. #1066

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 14, 2022

This is a backport of PR #618 as merged into stable-3 (cb2b186).

SUMMARY

Between Ansible Tower 3.6 and 3.7, the tag formatting changed for overriding the hostname variable. Users doing the 3.7 upgrade may be surprised when their inventories update with the ip##-##-##-##.example.com hostname format when they were previously able to import from AWS using the Name tag as the inventory identifier.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

ec2\

Update hostname_variable tag override example.

SUMMARY
Between Ansible Tower 3.6 and 3.7, the tag formatting changed for overriding the hostname variable. Users doing the 3.7 upgrade may be surprised when their inventories update with the ip##-##-##-##.example.com hostname format when they were previously able to import from AWS using the Name tag as the inventory identifier.
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
ec2\

Reviewed-by: Mark Chappell <None>
(cherry picked from commit cb2b186)
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 14, 2022
@ansibullbot ansibullbot added community_review docs inventory inventory plugin new_contributor Help guide this first time contributor small_patch Hopefully easy to review labels Apr 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 12c302c into stable-2 Apr 14, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-2/cb2b186fafe1385c6c2533f64a868a312839554b/pr-618 branch April 14, 2022 14:18
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…e_route53_utils

Promote route53 module_utils

SUMMARY

Promote route53 module_utils

ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…#1063)

Add route53 sanity ignore entry for 2.15 (devel)

Depends-On: ansible-collections#1066
SUMMARY
SSIA
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
tests/sanity
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
doc: Fix readme typo and misc

Depends-On: ansible-collections#1066
SUMMARY


Fix pip install command typo and formal name of FQCN.
ISSUE TYPE


Docs Pull Request

COMPONENT NAME


README.md

ADDITIONAL INFORMATION



n/a

Reviewed-by: Mark Chappell <None>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
new module: cloudwatch_metric_alarm_info

SUMMARY
Depends-On: ansible-collections#1066
Should be merged only after ansible-collections#1028 is merged.

Adding a new module for retrieving cloudwatch metric alarms info.

Currently supports following boto API(s)
describe_alarms()
ISSUE TYPE


New Module Pull Request

COMPONENT NAME

cloudwatch_metric_alarm_info
ADDITIONAL INFORMATION


Will be useful in moving these tasks from aws cli commands to amazon.aws module.
https://github.com/ansible-collections/community.aws/blob/main/tests/integration/targets/cloudwatch_metric_alarm/tasks/main.yml#L63-L70
ansible-collections#1440
The integration tests for this info module will be added to above tests, after the cloudwatch_metric_alarm module is migrated from community.aws to amazon.aws.

Sample playbook
---
- name: Create a metric alarm & get info
  hosts: localhost
  gather_facts: false
  tasks:
    - name: create alarm
      community.aws.cloudwatch_metric_alarm:
        state: present
        region: us-east-2
        name: "cpu-low-test-metric-alarm-1234"
        metric: "CPUUtilization"
        namespace: "AWS/EC2"
        statistic: Average
        comparison: "LessThanOrEqualToThreshold"
        threshold: 50.0
        period: 180
        evaluation_periods: 3
        unit: "Percent"
        description: "This will alarm when a instance's CPU usage average is lower than 50%"
        dimensions: {'InstanceId':'i-00a8b34xxxxxxxxxx'}

    - name: describe the metric alarm based on metric name and namespace
      amazon.aws.cloudwatch_metric_alarm_info:
        alarm_names:
          - cpu-low-test-metric-alarm-1234
      register: alarm_info

    - debug:
        var: alarm_info

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Jill R <None>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…ons#1026)

inventory/aws_ec2: allow multi-entries for one host

Depends-On: ansible-collections#1066
Add an option to allow multiple duplicated entries for one single instance.
Closes: ansible-collections#950

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Jill R <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
…le-collections#1037)

ec2_ami: Add support for params BootMode, TpmSupport, UefiData

SUMMARY
Depends-On: ansible-collections#1066

Added support for params BootMode, TpmSupport, UefiData in ec2_ami.

Fixes ansible-collections#944
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_ami
ADDITIONAL INFORMATION



Example playbook
- name: abc
  hosts: localhost
  gather_facts: false
  tasks:
    - name: AMI Creation with boot_mode and tpm_support
      amazon.aws.ec2_ami:
        name: ami-create-test_legacy-bios
        state: present
        architecture: x86_64
        virtualization_type: hvm
        root_device_name: /dev/sda1
        device_mapping:
          - device_name: /dev/sda1
            snapshot_id: snap-xxxxxxxxx
        wait: yes
        region: us-east-2
        boot_mode: legacy-bios
        tpm_support: v2.0
        tags:
          name: ami-create-test

Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Mike Graves <mgraves@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs inventory inventory plugin mergeit Merge the PR (SoftwareFactory) new_contributor Help guide this first time contributor small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants