Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #44/a3d519d9 backport][stable-3] New aws_api_gateway_domain module for adding custom domains #1065

Merged
merged 1 commit into from
Apr 16, 2022
Merged

[PR #44/a3d519d9 backport][stable-3] New aws_api_gateway_domain module for adding custom domains #1065

merged 1 commit into from
Apr 16, 2022

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Apr 14, 2022

This is a backport of PR #44 as merged into main (a3d519d).

SUMMARY

New module to setup a custom domain for AWS API Gateway services.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

aws_api_gateway_domain

ADDITIONAL INFORMATION

Complements already existing aws_api_gateway module to also allow custom domain setup.

Opened here as suggested in ansible PR ansible/ansible#68709

@stefanhorning @patchback
New aws_api_gateway_domain module for adding custom domains (#44)
176eb49 
New aws_api_gateway_domain module for adding custom domains

SUMMARY
New module to setup a custom domain for AWS API Gateway services.
ISSUE TYPE

New Module Pull Request

COMPONENT NAME
aws_api_gateway_domain
ADDITIONAL INFORMATION
Complements already existing aws_api_gateway module to also allow custom domain setup.
Opened here as suggested in ansible PR ansible/ansible#68709

Reviewed-by: Stefan Horning <None>
Reviewed-by: Jill R <None>
Reviewed-by: Sandra McCann <samccann@redhat.com>
Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
(cherry picked from commit a3d519d)
@patchback patchback bot mentioned this pull request Apr 14, 2022
Merged
markuman
markuman previously requested changes Apr 14, 2022
View reviewed changes
Copy link
Member

@markuman markuman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just like to block this backport until #1064 (comment) is clearified.
Otherwise we'll introduce a new modul in 3.2.1

@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @stefanhorning @tremble
click here for bot help

@ansibullbot ansibullbot added community_review integration tests/integration module module needs_triage new_contributor Help guide this first time contributor new_plugin New plugin plugins plugin (any type) tests tests labels Apr 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review new_plugin New plugin labels Apr 14, 2022
@markuman markuman dismissed their stale review April 16, 2022 05:35

goto stable-e now

@markuman markuman added the mergeit Merge the PR (SoftwareFactory) label Apr 16, 2022
@ansibullbot ansibullbot added community_review and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_triage labels Apr 16, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 6de04d9 into stable-3 Apr 16, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-3/a3d519d95047bf07cc1d9308056db28f2349d866/pr-44 branch April 16, 2022 05:57
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@akira6592
doc: Fix readme typo and misc (ansible-collections#1065)
9705493 
doc: Fix readme typo and misc

Depends-On: ansible-collections#1066
SUMMARY


Fix pip install command typo and formal name of FQCN.
ISSUE TYPE


Docs Pull Request

COMPONENT NAME


README.md

ADDITIONAL INFORMATION



n/a

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
community_review integration tests/integration mergeit Merge the PR (SoftwareFactory) module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ansibullbot @markuman @stefanhorning