Update hostname_variable tag override example. #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Between Ansible Tower 3.6 and 3.7, the tag formatting changed for overriding the hostname variable.
|
recheck |
|
@deekayen Sorry for the late delay. |
|
The script was removed in preparation for 4.0.0, I've moved this over to stable-3 where the script still exists |
tremble
approved these changes
Apr 14, 2022
|
Build succeeded (gate pipeline).
|
cb2b186
into
ansible-collections:stable-3
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #1066 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
Update hostname_variable tag override example. SUMMARY Between Ansible Tower 3.6 and 3.7, the tag formatting changed for overriding the hostname variable. Users doing the 3.7 upgrade may be surprised when their inventories update with the ip##-##-##-##.example.com hostname format when they were previously able to import from AWS using the Name tag as the inventory identifier. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2\ Reviewed-by: Mark Chappell <None> (cherry picked from commit cb2b186)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Apr 14, 2022
[PR #618/cb2b186f backport][stable-2] Update hostname_variable tag override example. This is a backport of PR #618 as merged into stable-3 (cb2b186). SUMMARY Between Ansible Tower 3.6 and 3.7, the tag formatting changed for overriding the hostname variable. Users doing the 3.7 upgrade may be surprised when their inventories update with the ip##-##-##-##.example.com hostname format when they were previously able to import from AWS using the Name tag as the inventory identifier. ISSUE TYPE Docs Pull Request COMPONENT NAME ec2\ Reviewed-by: Mark Chappell <None>
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
Fix on_denied and on_missing bugs SUMMARY This pull request: Changes the default value of on_denied to be error, so that it agrees with what is stated in the documentation. Changes the default value of on_missing to be error, and updates the documentation to explain this. Fixes ansible-collections#617. ISSUE TYPE Bugfix Pull Request COMPONENT NAME aws_ssm lookup Reviewed-by: Alina Buzachis <None> Reviewed-by: Shane Frasier <maverick@maverickdolphin.com> Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Between Ansible Tower 3.6 and 3.7, the tag formatting changed for overriding the hostname variable. Users doing the 3.7 upgrade may be surprised when their inventories update with the ip##-##-##-##.example.com hostname format when they were previously able to import from AWS using the Name tag as the inventory identifier.
ISSUE TYPE
COMPONENT NAME
ec2\