New Modules: AWS Network Firewall - rule groups #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
3cab926 to
b8ef6fe
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b8ef6fe to
8c11319
Compare
This comment was marked as outdated.
This comment was marked as outdated.
8c11319 to
9cce48a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9cce48a to
5712811
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5712811 to
6c96b90
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
This comment was marked as outdated.
This comment was marked as outdated.
|
@tremble We needed to temporarily back out the terminator policy changes. I'll try to sort those out tomorrow. |
Sure. Having problems with botocore versions? The terminator changes need at least botocore 1.19.20. FWIW this PR is only for the "Rule Groups", which have no direct costs associated with them. |
|
Sorry for the delay. This should be good from the terminator side of things. |
… tests to follow.
6c96b90 to
d029e83
Compare
This comment was marked as resolved.
This comment was marked as resolved.
d029e83 to
62d715e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
That did it, thanks @goneri |
alinabuzachis
approved these changes
Mar 15, 2022
62d715e to
8af9875
Compare
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…le-collections#1037) ec2_ami: Add support for params BootMode, TpmSupport, UefiData SUMMARY Depends-On: ansible-collections#1066 Added support for params BootMode, TpmSupport, UefiData in ec2_ami. Fixes ansible-collections#944 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_ami ADDITIONAL INFORMATION Example playbook - name: abc hosts: localhost gather_facts: false tasks: - name: AMI Creation with boot_mode and tpm_support amazon.aws.ec2_ami: name: ami-create-test_legacy-bios state: present architecture: x86_64 virtualization_type: hvm root_device_name: /dev/sda1 device_mapping: - device_name: /dev/sda1 snapshot_id: snap-xxxxxxxxx wait: yes region: us-east-2 boot_mode: legacy-bios tpm_support: v2.0 tags: name: ami-create-test Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mike Graves <mgraves@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorta-Depends-On: #974
SUMMARY
Two new modules for AWS Network Firewall rule groups. This first iteration will only support stateful rule groups.
networkfirewall_rule_group.py
networkfirewall_rule_group_info.py
ToDo:
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/networkfirewall.py
plugins/modules/networkfirewall_rule_group.py
plugins/modules/networkfirewall_rule_group_info.py
ADDITIONAL INFORMATION
Note: It's a deliberate choice not to support creation of stateless rules initially. I want to get some of the initial framework in place so that the Policy and Firewall pieces can be built out while waiting on reviews.