Additional 'base' helper classes #974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests to follow.
4 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
1 task
alinabuzachis
approved these changes
Mar 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 15, 2022
New Modules: AWS Network Firewall - rule groups Sorta-Depends-On: #974 SUMMARY Two new modules for AWS Network Firewall rule groups. This first iteration will only support stateful rule groups. networkfirewall_rule_group.py networkfirewall_rule_group_info.py ToDo: Initial modules Return Value documentation Integration Tests CI Permissions ISSUE TYPE New Module Pull Request COMPONENT NAME plugins/module_utils/networkfirewall.py plugins/modules/networkfirewall_rule_group.py plugins/modules/networkfirewall_rule_group_info.py ADDITIONAL INFORMATION Note: It's a deliberate choice not to support creation of stateless rules initially. I want to get some of the initial framework in place so that the Policy and Firewall pieces can be built out while waiting on reviews. Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #984
SUMMARY
Working on #944 and some additional modules, I want to add support for --diff. The API for NetworkFirewall also has some interesting requirements due to its use of opportunistic locking.
These classes provide the initial framework I'm using for this. Once I've got the modules themselves landed I'll get unit tests for these classes written. Note: some of this code currently overlaps with code currently available in amazon.aws, I want to prove things out here in community.aws before migrating them over to amazon.aws
ISSUE TYPE
COMPONENT NAME
plugin/module_utils/base.py
ADDITIONAL INFORMATION
Dependent PRs: