Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spy-plugin-registry-teardown] PR: Migrate Outline explorer, plots, preferences and profiler to use the new teardown mechanism #7

Merged
merged 29 commits into from
Oct 6, 2021
Merged

[spy-plugin-registry-teardown] PR: Migrate Outline explorer, plots, preferences and profiler to use the new teardown mechanism #7

merged 29 commits into from
Oct 6, 2021

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jul 15, 2021 •
edited
Loading

Stacked PR Chain: [spy-plugin-registry-teardown]

PR Title Merges Into
spyder-ide#16012 [spy-plugin-registry-teardown] PR: Add plugin teardown operations to the plugin registry N/A
#1 [spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism spyder-ide#16012
#2 [spy-plugin-registry-teardown] PR: Migrate breakpoints to use the new teardown mechanism #1
#3 [spy-plugin-registry-teardown] PR: Migrate completions plugin to use the new teardown mechanism #2
#4 [spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism #3
#5 [spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism #4
#6 [spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism #5
#7 [spy-plugin-registry-teardown] PR: Migrate Outline explorer, plots, preferences and profiler to use the new teardown mechanism #6
#8 [spy-plugin-registry-teardown] PR: Migrate projects to use the new teardown mechanism #7
#9 [spy-plugin-registry-teardown] PR: Migrate pylint, run and shortcuts to use the new teardown mechanism #8
#10 [spy-plugin-registry-teardown] PR: Migrate statusbar, toolbar and tours to use the new teardown mechanism #9
#11 [spy-plugin-registry-teardown] PR: Migrate variable explorer and working directory to use the new teardown mechanism #10
#12 [spy-plugin-registry-teardown] PR: Add preference page to enable and disable plugins #11

This was referenced Jul 15, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the history_layouts_teardown branch from 0c00249 to 437486e Compare July 16, 2021 16:35
@andfoy andfoy force-pushed the outlineplotsprefprof_teardown branch 2 times, most recently from 240142e to ca7fb38 Compare July 16, 2021 19:13
This was referenced Jul 19, 2021
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the history_layouts_teardown branch from 883600a to 9789dc7 Compare August 30, 2021 19:53
@andfoy andfoy force-pushed the outlineplotsprefprof_teardown branch 2 times, most recently from 5e8befd to ce6a1dc Compare August 30, 2021 22:00
@andfoy andfoy force-pushed the history_layouts_teardown branch from 84103e4 to da43d80 Compare August 31, 2021 17:24
@andfoy andfoy force-pushed the outlineplotsprefprof_teardown branch 4 times, most recently from dba734c to 7283fb6 Compare August 31, 2021 22:44
@andfoy andfoy force-pushed the history_layouts_teardown branch from 608e798 to e3e7db9 Compare August 31, 2021 22:49
@andfoy andfoy force-pushed the outlineplotsprefprof_teardown branch 2 times, most recently from 9a8a7ae to e068953 Compare August 31, 2021 22:53
@andfoy andfoy force-pushed the history_layouts_teardown branch 2 times, most recently from d725f04 to b914671 Compare August 31, 2021 23:02
@andfoy andfoy force-pushed the outlineplotsprefprof_teardown branch from e068953 to 87c2efb Compare August 31, 2021 23:02
@andfoy andfoy force-pushed the history_layouts_teardown branch from b914671 to d4653de Compare August 31, 2021 23:05
@andfoy andfoy force-pushed the outlineplotsprefprof_teardown branch from efaad2e to 36e53bf Compare October 5, 2021 17:02
andfoy added 26 commits October 6, 2021 14:20
@andfoy
Migrate projects to use the new teardown mechanism
7fff30d
@andfoy
Update calls to remove_item_from_application_menu
5a92176
@andfoy
Address review comments
670a04f
@andfoy
Address further review comments
de3121a
@andfoy
Minor error correction
b632039
@andfoy
Restore sig_stop_completions connection
e3493ae
@andfoy
Migrate pylint, run and shortcuts to use the new teardown mechanism
3c2a2df
@andfoy
Remove hard reference to editor in pylint
2f8c441
@andfoy
Update calls to remove_item_from_application_menu
ac86d4e
@andfoy
Address review comments
b0f4124
@andfoy
Final review comments
e55537a
@andfoy
Migrate statusbar, toolbar and tours to use the new teardown mechanism
b5f85e4
@andfoy
Update calls to remove_item_from_application_menu
6a88ed1
@andfoy
Address review comments
9dfa461
@andfoy
Add proper signature to statusbar on_close method
d6b0402
@andfoy
Address review comments
f168c46
@andfoy
Migrate variable explorer and working directory to use the new teardo…
16a7d94 
…wn mechanism
@andfoy
Update calls to remove_item_from_application_menu
c20dc2c
@andfoy
Apply review comments
de4aa37
@andfoy
Remove duplicate on__close
63751fe
@andfoy
Add preference page to enable and disable plugins
ed2cdc0
@andfoy
Restart Spyder after a plugin is enabled/disabled
5a0b06d
@andfoy
Disable also Spyder 4 plugins
ec17134
@andfoy
Fix test_preferences_checkboxes_not_checked_regression
421e4e9
@andfoy
Address review comments
a331e93
@andfoy
Always add external plugin metadata
632f55f
@andfoy andfoy merged commit f90bd45 into history_layouts_teardown Oct 6, 2021
@andfoy andfoy deleted the outlineplotsprefprof_teardown branch October 6, 2021 19:21
andfoy pushed a commit that referenced this pull request Feb 14, 2022
@rear1019
pyside: Do not pass “None” to QTreeView.setExpanded()
80fb661 
PySide2 crashes otherwise (as of PySide2/Qt 5.15.0):

Received signal 6
#0 0x7fecd2bcea7b base::debug::CollectStackTrace()
#1 0x7fecd299bbaf base::debug::StackTrace::StackTrace()
#2 0x7fecd299bb62 base::debug::StackTrace::StackTrace()
#3 0x7fecd2bcd61e base::debug::(anonymous namespace)::StackDumpSignalHandler()
#4 0x7fed08461210 <unknown>
#5 0x7fed0846118b gsignal
#6 0x7fed08440859 abort
#7 0x7fed08119882 fatal_error.lto_priv.0
#8 0x7fed0811989f Py_FatalError
#9 0x7fed03c8c50b SetError_Argument
#10 0x7fed03c5d64e Shiboken::setErrorAboutWrongArguments()
#11 0x7fece240f259 Sbk_QTreeViewFunc_setExpanded
<shortened>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andfoy @ccordoba12