Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism #5

Merged
merged 35 commits into from
Oct 6, 2021
Merged

[spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism #5

merged 35 commits into from
Oct 6, 2021

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jul 15, 2021 •
edited
Loading

Stacked PR Chain: [spy-plugin-registry-teardown]

PR Title Merges Into
spyder-ide#16012 [spy-plugin-registry-teardown] PR: Add plugin teardown operations to the plugin registry N/A
#1 [spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism spyder-ide#16012
#2 [spy-plugin-registry-teardown] PR: Migrate breakpoints to use the new teardown mechanism #1
#3 [spy-plugin-registry-teardown] PR: Migrate completions plugin to use the new teardown mechanism #2
#4 [spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism #3
#5 [spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism #4
#6 [spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism #5
#7 [spy-plugin-registry-teardown] PR: Migrate Outline explorer, plots, preferences and profiler to use the new teardown mechanism #6
#8 [spy-plugin-registry-teardown] PR: Migrate projects to use the new teardown mechanism #7
#9 [spy-plugin-registry-teardown] PR: Migrate pylint, run and shortcuts to use the new teardown mechanism #8
#10 [spy-plugin-registry-teardown] PR: Migrate statusbar, toolbar and tours to use the new teardown mechanism #9
#11 [spy-plugin-registry-teardown] PR: Migrate variable explorer and working directory to use the new teardown mechanism #10
#12 [spy-plugin-registry-teardown] PR: Add preference page to enable and disable plugins #11

This was referenced Jul 15, 2021
Merged
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the help_plugin_teardown branch 3 times, most recently from d47bec9 to 6db5622 Compare July 15, 2021 20:57
@andfoy andfoy mentioned this pull request Jul 15, 2021
Merged
@andfoy andfoy changed the title [spy-plugin-registry-teardown] PR: Help plugin teardown [spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism Jul 15, 2021
This was referenced Jul 15, 2021
Merged
Merged
@andfoy andfoy force-pushed the help_plugin_teardown branch from 6db5622 to 6ab594a Compare July 16, 2021 16:35
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch from 5b8b359 to e842e4d Compare July 16, 2021 19:13
@andfoy andfoy force-pushed the help_plugin_teardown branch from 6ab594a to bf0e293 Compare July 16, 2021 19:13
This was referenced Jul 19, 2021
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch from e842e4d to da5ef10 Compare August 30, 2021 19:53
@andfoy andfoy force-pushed the help_plugin_teardown branch from bf0e293 to 1a07e86 Compare August 30, 2021 19:53
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch from da5ef10 to e205990 Compare August 30, 2021 22:00
@andfoy andfoy force-pushed the help_plugin_teardown branch 4 times, most recently from 42c8c15 to fe0588e Compare August 31, 2021 22:35
@andfoy andfoy force-pushed the console_explorer_find_plugins_teardown branch from 36fc27e to 97b1747 Compare August 31, 2021 22:44
@andfoy andfoy force-pushed the help_plugin_teardown branch 3 times, most recently from ec2f7a4 to e24b3b5 Compare August 31, 2021 22:53
andfoy added 27 commits October 6, 2021 14:21
@andfoy
Address review comments
a03c088
@andfoy
Migrate projects to use the new teardown mechanism
5883605
@andfoy
Update calls to remove_item_from_application_menu
b558f62
@andfoy
Address review comments
3d1d7ac
@andfoy
Address further review comments
2a78920
@andfoy
Minor error correction
c4a1bde
@andfoy
Restore sig_stop_completions connection
97dc42f
@andfoy
Migrate pylint, run and shortcuts to use the new teardown mechanism
30985ba
@andfoy
Remove hard reference to editor in pylint
ffde5ad
@andfoy
Update calls to remove_item_from_application_menu
65009a4
@andfoy
Address review comments
2acdd1f
@andfoy
Final review comments
2bd4809
@andfoy
Migrate statusbar, toolbar and tours to use the new teardown mechanism
e57cc38
@andfoy
Update calls to remove_item_from_application_menu
fe38a97
@andfoy
Address review comments
068550e
@andfoy
Add proper signature to statusbar on_close method
a7c273c
@andfoy
Address review comments
7362068
@andfoy
Migrate variable explorer and working directory to use the new teardo…
60af997 
…wn mechanism
@andfoy
Update calls to remove_item_from_application_menu
6e0f6e9
@andfoy
Apply review comments
fd705bd
@andfoy
Remove duplicate on__close
a02af89
@andfoy
Add preference page to enable and disable plugins
f542764
@andfoy
Restart Spyder after a plugin is enabled/disabled
1230dbc
@andfoy
Disable also Spyder 4 plugins
79c16f0
@andfoy
Fix test_preferences_checkboxes_not_checked_regression
6a62371
@andfoy
Address review comments
aa1af69
@andfoy
Always add external plugin metadata
c06bfc7
@andfoy andfoy merged commit 9f84e98 into console_explorer_find_plugins_teardown Oct 6, 2021
@andfoy andfoy deleted the help_plugin_teardown branch October 6, 2021 19:21
andfoy pushed a commit that referenced this pull request Feb 14, 2022
@rear1019
pyside: Do not pass “None” to QTreeView.setExpanded()
80fb661 
PySide2 crashes otherwise (as of PySide2/Qt 5.15.0):

Received signal 6
#0 0x7fecd2bcea7b base::debug::CollectStackTrace()
#1 0x7fecd299bbaf base::debug::StackTrace::StackTrace()
#2 0x7fecd299bb62 base::debug::StackTrace::StackTrace()
#3 0x7fecd2bcd61e base::debug::(anonymous namespace)::StackDumpSignalHandler()
#4 0x7fed08461210 <unknown>
#5 0x7fed0846118b gsignal
#6 0x7fed08440859 abort
#7 0x7fed08119882 fatal_error.lto_priv.0
#8 0x7fed0811989f Py_FatalError
#9 0x7fed03c8c50b SetError_Argument
#10 0x7fed03c5d64e Shiboken::setErrorAboutWrongArguments()
#11 0x7fece240f259 Sbk_QTreeViewFunc_setExpanded
<shortened>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andfoy @ccordoba12