Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism #6

Merged
merged 32 commits into from
Oct 6, 2021
Merged

[spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism #6

merged 32 commits into from
Oct 6, 2021

Conversation

andfoy
Copy link
Owner

@andfoy andfoy commented Jul 15, 2021 •
edited
Loading

Stacked PR Chain: [spy-plugin-registry-teardown]

PR Title Merges Into
spyder-ide#16012 [spy-plugin-registry-teardown] PR: Add plugin teardown operations to the plugin registry N/A
#1 [spy-plugin-registry-teardown] PR: Migrate application teardown to use the new teardown mechanism spyder-ide#16012
#2 [spy-plugin-registry-teardown] PR: Migrate breakpoints to use the new teardown mechanism #1
#3 [spy-plugin-registry-teardown] PR: Migrate completions plugin to use the new teardown mechanism #2
#4 [spy-plugin-registry-teardown] PR: Migrate Console, Explorer and Find in files to use the new teardown mechanism #3
#5 [spy-plugin-registry-teardown] PR: Migrate help to use the new teardown mechanism #4
#6 [spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism #5
#7 [spy-plugin-registry-teardown] PR: Migrate Outline explorer, plots, preferences and profiler to use the new teardown mechanism #6
#8 [spy-plugin-registry-teardown] PR: Migrate projects to use the new teardown mechanism #7
#9 [spy-plugin-registry-teardown] PR: Migrate pylint, run and shortcuts to use the new teardown mechanism #8
#10 [spy-plugin-registry-teardown] PR: Migrate statusbar, toolbar and tours to use the new teardown mechanism #9
#11 [spy-plugin-registry-teardown] PR: Migrate variable explorer and working directory to use the new teardown mechanism #10
#12 [spy-plugin-registry-teardown] PR: Add preference page to enable and disable plugins #11

This was referenced Jul 15, 2021
Merged
Merged
Merged
Merged
Merged
@andfoy andfoy changed the title [spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mmechanism [spy-plugin-registry-teardown] PR: Migrate history and layouts to use the new teardown mechanism Jul 15, 2021
This was referenced Jul 15, 2021
Merged
Merged
Merged
@andfoy andfoy force-pushed the help_plugin_teardown branch from 6db5622 to 6ab594a Compare July 16, 2021 16:35
@andfoy andfoy force-pushed the history_layouts_teardown branch from 0c00249 to 437486e Compare July 16, 2021 16:35
@andfoy andfoy force-pushed the help_plugin_teardown branch from 6ab594a to bf0e293 Compare July 16, 2021 19:13
@andfoy andfoy force-pushed the history_layouts_teardown branch from 437486e to 883600a Compare July 16, 2021 19:13
This was referenced Jul 19, 2021
Merged
Merged
Merged
Merged
@andfoy andfoy force-pushed the history_layouts_teardown branch 3 times, most recently from 84103e4 to da43d80 Compare August 31, 2021 17:24
@andfoy andfoy force-pushed the help_plugin_teardown branch from a1ee120 to cccfdb8 Compare August 31, 2021 21:19
@andfoy andfoy force-pushed the history_layouts_teardown branch from da43d80 to 6a9aa90 Compare August 31, 2021 21:19
@andfoy andfoy force-pushed the help_plugin_teardown branch from 42c8c15 to fe0588e Compare August 31, 2021 22:35
@andfoy andfoy force-pushed the history_layouts_teardown branch from da787d6 to 14ef1a1 Compare August 31, 2021 22:35
@andfoy andfoy force-pushed the help_plugin_teardown branch from fe0588e to 75c2d83 Compare August 31, 2021 22:44
@andfoy andfoy force-pushed the history_layouts_teardown branch from 14ef1a1 to 608e798 Compare August 31, 2021 22:44
@andfoy andfoy force-pushed the help_plugin_teardown branch from 75c2d83 to ec2f7a4 Compare August 31, 2021 22:49
@andfoy andfoy force-pushed the history_layouts_teardown branch from 608e798 to e3e7db9 Compare August 31, 2021 22:49
@andfoy andfoy force-pushed the help_plugin_teardown branch from ec2f7a4 to e24b3b5 Compare August 31, 2021 22:53
@andfoy andfoy force-pushed the history_layouts_teardown branch from e3e7db9 to d725f04 Compare August 31, 2021 22:53
andfoy added 27 commits October 6, 2021 14:21
@andfoy
Address review comments
4774998
@andfoy
Migrate projects to use the new teardown mechanism
1e68172
@andfoy
Update calls to remove_item_from_application_menu
5cdaa48
@andfoy
Address review comments
bdd8ff5
@andfoy
Address further review comments
548d0b2
@andfoy
Minor error correction
664bd48
@andfoy
Restore sig_stop_completions connection
1ef49d6
@andfoy
Migrate pylint, run and shortcuts to use the new teardown mechanism
1d75bf1
@andfoy
Remove hard reference to editor in pylint
ad5b266
@andfoy
Update calls to remove_item_from_application_menu
2114985
@andfoy
Address review comments
1d46beb
@andfoy
Final review comments
d9edb92
@andfoy
Migrate statusbar, toolbar and tours to use the new teardown mechanism
e404feb
@andfoy
Update calls to remove_item_from_application_menu
a985871
@andfoy
Address review comments
a8f0223
@andfoy
Add proper signature to statusbar on_close method
2b7422c
@andfoy
Address review comments
83eff27
@andfoy
Migrate variable explorer and working directory to use the new teardo…
6278db9 
…wn mechanism
@andfoy
Update calls to remove_item_from_application_menu
d46590e
@andfoy
Apply review comments
06d4842
@andfoy
Remove duplicate on__close
c35c508
@andfoy
Add preference page to enable and disable plugins
73f9bc8
@andfoy
Restart Spyder after a plugin is enabled/disabled
f6f6827
@andfoy
Disable also Spyder 4 plugins
e9e1902
@andfoy
Fix test_preferences_checkboxes_not_checked_regression
23d2ed6
@andfoy
Address review comments
2f59941
@andfoy
Always add external plugin metadata
f90bd45
@andfoy andfoy merged commit c06bfc7 into help_plugin_teardown Oct 6, 2021
@andfoy andfoy deleted the history_layouts_teardown branch October 6, 2021 19:21
andfoy pushed a commit that referenced this pull request Feb 14, 2022
@rear1019
pyside: Do not pass “None” to QTreeView.setExpanded()
80fb661 
PySide2 crashes otherwise (as of PySide2/Qt 5.15.0):

Received signal 6
#0 0x7fecd2bcea7b base::debug::CollectStackTrace()
#1 0x7fecd299bbaf base::debug::StackTrace::StackTrace()
#2 0x7fecd299bb62 base::debug::StackTrace::StackTrace()
#3 0x7fecd2bcd61e base::debug::(anonymous namespace)::StackDumpSignalHandler()
#4 0x7fed08461210 <unknown>
#5 0x7fed0846118b gsignal
#6 0x7fed08440859 abort
#7 0x7fed08119882 fatal_error.lto_priv.0
#8 0x7fed0811989f Py_FatalError
#9 0x7fed03c8c50b SetError_Argument
#10 0x7fed03c5d64e Shiboken::setErrorAboutWrongArguments()
#11 0x7fece240f259 Sbk_QTreeViewFunc_setExpanded
<shortened>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andfoy @ccordoba12