Address review comments

andfoy · Oct 5, 2021 · 36e53bf · 36e53bf
1 parent 895bd84
commit 36e53bf
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 5 deletions.
diff --git a/spyder/plugins/maininterpreter/plugin.py b/spyder/plugins/maininterpreter/plugin.py
@@ -88,8 +88,7 @@ def on_preferences_available(self):
     def on_statusbar_available(self):
         # Add status widget
         statusbar = self.get_plugin(Plugins.StatusBar)
-        if statusbar:
-            statusbar.add_status_widget(self.interpreter_status)
+        statusbar.add_status_widget(self.interpreter_status)
 
     @on_plugin_teardown(plugin=Plugins.Preferences)
     def on_preferences_teardown(self):
@@ -101,8 +100,7 @@ def on_preferences_teardown(self):
     def on_statusbar_teardown(self):
         # Add status widget
         statusbar = self.get_plugin(Plugins.StatusBar)
-        if statusbar:
-            statusbar.remove_status_widget(self.interpreter_status.ID)
+        statusbar.remove_status_widget(self.interpreter_status.ID)
 
     # ---- Public API
     def get_interpreter(self):

diff --git a/spyder/plugins/outlineexplorer/plugin.py b/spyder/plugins/outlineexplorer/plugin.py
@@ -73,6 +73,13 @@ def on_completions_teardown(self):
         completions.sig_stop_completions.disconnect(
             self.stop_symbol_services)
 
+    @on_plugin_teardown(plugin=Plugins.Editor)
+    def on_editor_teardown(self):
+        editor = self.get_plugin(Plugins.Editor)
+
+        editor.sig_open_files_finished.disconnect(
+            self.update_all_editors)
+
     #------ Public API ---------------------------------------------------------
     def restore_scrollbar_position(self):
         """Restoring scrollbar position after main window is visible"""

diff --git a/spyder/plugins/profiler/plugin.py b/spyder/plugins/profiler/plugin.py
@@ -122,7 +122,9 @@ def on_main_menu_teardown(self):
         mainmenu = self.get_plugin(Plugins.MainMenu)
 
         mainmenu.remove_item_from_application_menu(
-            ProfilerActions.ProfileCurrentFile, menu_id=ApplicationMenus.Run)
+            ProfilerActions.ProfileCurrentFile,
+            menu_id=ApplicationMenus.Run
+        )
 
     # --- Public API
     # ------------------------------------------------------------------------