[calibration] Checkerboard detection #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servantftechnicolor
previously approved these changes
Jan 20, 2023
simogasp
requested changes
Jan 20, 2023
simogasp
requested changes
Jan 20, 2023
simogasp
previously requested changes
Jan 20, 2023
…ort nested checkerboards
…and minor corrections
0c7d553 to
4efca48
Compare
|
Rebased on develop and re-tested :) |
|
|
||
| // write the json file with the tree | ||
| ALICEVISION_LOG_INFO("Writing detection output in " << "checkers_" << viewId << ".json"); | ||
| std::stringstream ss; |
fabiencastan
approved these changes
Apr 12, 2023
cbentejac
added a commit
that referenced
this pull request
Apr 17, 2023
Following the merge of #1331, the `boost-json` module is needed and thus needs to be installed along all the other Boost modules.
cbentejac
added a commit
that referenced
this pull request
Apr 19, 2023
Following the merge of #1331, the `boost-json` module is needed and thus needs to be installed along all the other Boost modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new checkerboard detection software and improves the previous checkerboard detection algorithm.
The detection code was cherry-picked from this PR: #1291.
The corresponding Meshroom node has been introduced in this PR: alicevision/Meshroom#1869.
Features list
Tests
Tested on: