Undistortion model and rewrite the calibration code #1291
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cde6209 to
f5b2b82
Compare
| @@ -251,7 +251,7 @@ bool process_innerGrids(sfmData::SfMData& sfmData, std::map<IndexT, calibration: | |||
|
|
|||
| //Create pose | |||
| sfmData::CameraPose newPose(geometry::Pose3(R, -R.transpose() * t)); | |||
| newPose.setDistance(distances[pos_view]); | |||
| //newPose.setDistance(distances[pos_view]); | |||
4de9b4c to
00e0fdc
Compare
…ort nested checkerboards
…only work for anamorphic4 cameras atm)
…ions and undistortion
…bject instead of a distortion object
6a4bd6e to
b8874d3
Compare
fabiencastan
requested changes
Nov 27, 2022
| sfmData::Rig rig(2); | ||
| output.getRigs()[0] = rig; | ||
|
|
||
| std::map<int, std::vector<std::shared_ptr<sfmData::View>>> paired_views; |
| for (auto b : _boards) | ||
| { | ||
| bool isWeird = false; | ||
|
|
There was a problem hiding this comment.
It would be good to have some comments explaining the cases that we want to detect to consider as invalid.
| { | ||
| const std::vector<CheckerBoardCorner> & corners = _corners; | ||
|
|
||
| //Sort bvoards by their minimal distance to image center |
| @@ -272,7 +272,7 @@ endif() | |||
| # Boost | |||
| # ============================================================================== | |||
| option(BOOST_NO_CXX11 "if Boost is compiled without C++11 support (as it is often the case in OS packages) this must be enabled to avoid symbol conflicts (SCOPED_ENUM)." OFF) | |||
| set(ALICEVISION_BOOST_COMPONENTS atomic container date_time filesystem graph log log_setup program_options regex serialization system thread timer) | |||
| set(ALICEVISION_BOOST_COMPONENTS atomic container date_time filesystem graph log log_setup program_options regex serialization system thread timer json) | |||
5000404 to
b8874d3
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checkerboard detection is extracted from distortionCalibration and now a pipeline executable by itself (for parallelization purpose)
Output is a set of json files
I added Boost json which is a modern implementation of a json parser (instead of property_trees)
A new program for intrinsics calibration is also added