Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nodes] New CheckerboardDetection node #1869

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Conversation

mugulmd
Copy link
Contributor

@mugulmd mugulmd commented Jan 13, 2023

Description

This PR introduces a new node for the checkerboard detection software from this PR: alicevision/AliceVision#1331.

The base structure of the node has been cherry-picked from this PR: #1643.

Features

This node also provides a mean to visualize the detection results:

  • check the Export Debug Images checkbox
  • once calculations are done, double-click the node to see the detected checkerboards appear in the 2D viewer.
    If several checkerboards are detected, they will appear in different colors.

@mugulmd mugulmd self-assigned this Jan 13, 2023
@mugulmd mugulmd changed the title Mug/checkerboard detection [nodes] New CheckerboardDetection node Jan 18, 2023
@mugulmd mugulmd marked this pull request as ready for review January 18, 2023 15:24
@mugulmd mugulmd force-pushed the mug/checkerboardDetection branch from a7cae52 to 480c03b Compare March 14, 2023 09:51
@mugulmd
Copy link
Contributor Author

mugulmd commented Mar 14, 2023

Rebased on develop and re-tested :)

@fabiencastan fabiencastan added this to the Meshroom 2023.2.0 milestone Apr 12, 2023
@fabiencastan fabiencastan merged commit f83db77 into develop Apr 12, 2023
@fabiencastan fabiencastan deleted the mug/checkerboardDetection branch April 12, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants