Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodes] calibration nodes #1643

Closed
wants to merge 13 commits into from
Closed

[nodes] calibration nodes #1643

wants to merge 13 commits into from

Conversation

servantftechnicolor
Copy link
Contributor

Add calibration nodes :

  • 1 node for checkerboard detection
  • 1 node for distortion estimation from checkerboards
  • 1 node for intrinsics estimation from checkerboards

@natowi
Copy link
Member

natowi commented Mar 11, 2022 •
edited
Loading

Can the sfmData.sfm now be used as input for the CameraInit node? If not, that would be great :)

@servantftechnicolor
Copy link
Contributor Author

Can the sfmData.sfm now be used as input for the CameraInit node? If not, that would be great :)

Currently we can use sfmtransfer to copy intrinsics to the output of camera init. However, it may be not user friendly?

@natowi
Copy link
Member

natowi commented Mar 12, 2022 •
edited
Loading

Using the input in the CameraInit node would be more intuitive I think: grafik
Using the existing intrinsics input or enabling a sfmData input in the camerainit node could be an option

natowi
natowi reviewed Mar 21, 2022
View reviewed changes
meshroom/nodes/aliceVision/RigCreate.py
category = 'Other'
documentation = '''
Create a rig from multiple input sfm files.
No modification is done on the data. Rig calibration is not performed here.
Copy link
Member

@natowi natowi Mar 21, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better: Rig calibration is performed in the CheckerboardRigCalibration node.

@fabiencastan fabiencastan added this to the Meshroom 2022.1.0 milestone Apr 25, 2022
@stale
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale for issues that becomes stale (no solution) label Nov 2, 2022
@natowi natowi added do not close issue that should stay open (avoid automatically close because stale) and removed stale for issues that becomes stale (no solution) labels Nov 3, 2022
@servantftechnicolor servantftechnicolor force-pushed the dev/checkerBoardDetectionNode branch from 1fc2b37 to 727a074 Compare November 9, 2022 14:34
@mugulmd mugulmd mentioned this pull request Jan 13, 2023
Merged
@fabiencastan fabiencastan marked this pull request as draft June 7, 2023 16:14
@fabiencastan fabiencastan removed this from the Meshroom 2023.2.0 milestone Jun 14, 2023
@fabiencastan fabiencastan removed the do not close issue that should stay open (avoid automatically close because stale) label Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natowi natowi natowi left review comments

@fabiencastan fabiencastan Awaiting requested review from fabiencastan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@servantftechnicolor @natowi @fabiencastan