forked from palantir/tslint
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples for tslint-documentation #2
Open
Shinigami92
wants to merge
91
commits into
aervin:docs/code-examples
Choose a base branch
from
Shinigami92:docs/code-examples
base: docs/code-examples
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Examples for tslint-documentation #2
Shinigami92
wants to merge
91
commits into
aervin:docs/code-examples
from
Shinigami92:docs/code-examples
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[no-log] This doesn't change our public API.
[bugfix] `no-unsafe-any` allows spreading an `any`-value into an object
[bugfix] `callable-types` adds parentheses when fixing a type literal inside an array type
…per and object-literal-sort-keys
Accidentally committed formatting that VSCode did, has nothing to do with the commit
fixed vscode's formatting
…#3729) * Improve "no valid rules" error message to include file type * Lint
* Excluded native JSX elements from no-unsafe-any * Lint fix: double-apostrophe Interesting how TypeScript auto-added single-apostrophes... * ...almost working.. * Split no-unsafe-any into separate tests * Added test cases for fragments * Added case for TS2.1 and fragments
* Prepare release 5.10.0
```diff + for - or ```
- Updated docs to make sense semantically (use vars that should exist in the scope of each for-loop) - Updated tests with same issue
* no-empty: ensure rule works for typed functions * no-empty: prove lack of methods handling * fix
Some Walker fields had to be initialized with inline initializers.
palantir#3876) * ignoring identifiers whose parent is a binding element * check that ignored identifier is propname of binding element * additional tests
JSON.stringify fails in some cases because its fails to convert circular structure to string
…me error (palantir#3919) * fix no-unused-variable-rule for typescript@next * fix ignore pattern test file as well * fix tests * deprecate noUnusedVariableRule for TS 2.9+ * use semver for cleaner comparison check
… it's deprecated for (palantir#3958)
…ir#3985) (node:16148) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead. allocUnsafe should be fine because in both cases, the buffer is immediately filled and thrown out.
…alantir#3935) * Implemented fixer for member-ordering and added corresponding tests. * Improved node boundary calculation so trivia remains attached to the correct nodes. * minor comment fixes.
….Number.parseInt() (palantir#3901)
* add fileNameCasing rule * use camel case name for tslintCli * refactor casing check into helper function * use stylized name for casing in failure message
…r#3839) (palantir#3979) * feature - no-implicit-dependencies - add whitelist (palantir#3839) This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases * feature - no-implicit-dependencies - add whitelist (palantir#3839) Use Set for whitelist package name comparison instead of Array.
palantir#4019) * Fix CI, which became red after consequent merge palantir#3979, palantir#3875 * Upgrade typescript@2.9.2, tsutils@2.27.2 * Remove unneded type assertion after typescript upgrade * Add runtime check for 'ts.unescapeIdentifier()' presence
The GitHub GUI is a bit confusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Is there anything you'd like reviewers to focus on?
I'm not an english native speaker, pls check my sentences :)
CHANGELOG.md entry:
[enhancement] Documentation examples for following rules:
arrow-return-shorthand
,class-name
,no-any
,no-empty-interface
,no-sparse-arrays
,no-unnecessary-callback-wrapper
,object-literal-sort-keys
,one-variable-per-declaration
,only-arrow-functions
,prefer-template
,radix
,switch-default
,typedef
,use-isnan