Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Handle tsconfig.json errors without using JSON.stringify #3908

Merged
merged 1 commit into from
Jun 7, 2018

Conversation

mertdeg2
Copy link
Contributor

JSON.stringify fails in some cases because its fails to convert circular structure to string

PR checklist

  • Addresses an existing issue: #0000
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

Is there anything you'd like reviewers to focus on?

CHANGELOG.md entry:

JSON.stringify fails in some cases because its fails to convert circular structure to string
@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @mertdeg2! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@suchanlee
Copy link
Contributor

what issue does this fix?

@mertdeg2
Copy link
Contributor Author

Without this change, TSLint chokes while trying to report failures. Some failures contain circular structures. And JSON.stringify can’t handle those

Copy link

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i've seen this used before. nice.

@suchanlee suchanlee merged commit 175a586 into palantir:master Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants