-
Notifications
You must be signed in to change notification settings - Fork 885
Accept whitelist for no-implicit-dependencies #3839
Comments
My use case is slightly different. Assume the following paths in the
Although it won't be easy to parse the paths when linting I'd like to see the whitelist as a workaround which should be a lot easier to implement. |
This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases
This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases
i also find myself disabling |
Use Set for whitelist package name comparison instead of Array.
…3979) * feature - no-implicit-dependencies - add whitelist (#3839) This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases * feature - no-implicit-dependencies - add whitelist (#3839) Use Set for whitelist package name comparison instead of Array.
The whitelist should fix this issue, however for @nearautomata it may still be a problem because the rule handles imports starting with |
@ajcrites Thanks for your great works! I'm happy that this option has been added :) |
…r#3839) (palantir#3979) * feature - no-implicit-dependencies - add whitelist (palantir#3839) This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases * feature - no-implicit-dependencies - add whitelist (palantir#3839) Use Set for whitelist package name comparison instead of Array.
I think the fix for this has been merged (and should be released shortly). Going to close this for now - feel free to reopen it if need be. |
I would like to specify whitelists for
no-implicit-dependencies
because of webpack externals options.TypeScript code being linted
webpack.config.js:
I guess this rule should accept whitelists as options. However, since the current option only accepts the type of dependencies, this is breaking change.
Is such a feature accepted?
The text was updated successfully, but these errors were encountered: