This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
Added no-dynamic-delete rule #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 22, 2017 14:07
Equivalent to tslint-microsoft-contrib's no-delete-expression. Renamed because all deletes are technically of node kind DeleteExpression, though they may sometimes contain an expression as the argumentExpression. Allowed string literals of invalid property accesses, numeric literals, and negative numeric literals because those can't be simplified. Suggested fixes for converting valid string literals to direct lookups and simplified unnecessarily positive numbers (like `+7` to `7`).
adidahiya
approved these changes
Jan 9, 2018
src/rules/noDynamicDeleteRule.ts
Outdated
|
|
||
| export class Rule extends Lint.Rules.AbstractRule { | ||
| public static metadata: Lint.IRuleMetadata = { | ||
| description: "Enforces not deleting computed expressions.", |
There was a problem hiding this comment.
"Bans usage of the delete operator with computed key expressions"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to tslint-microsoft-contrib's no-delete-expression. Renamed because all deletes are technically of node kind DeleteExpression, though they may sometimes contain an expression as the argumentExpression.
Allowed string literals of invalid property accesses, numeric literals, and negative numeric literals because those can't be simplified.
Suggested fixes for converting valid string literals to direct lookups and simplified unnecessarily positive numbers (like
+7to7).Fixes #3553.
CHANGELOG.md entry:
[new-rule]
no-dynamic-delete