Share improvements

[rsammelson]

Fixes #183 and adds modal to select what the user would like to share (link to post or link to post content). Fixes #255. Also should fix #474.

[rsammelson]

I'm guessing I should move the toast to the bottom. I didn't like how it covered the bottom bar, but now I realize that is a general issue that needs to be solved (#147).

[rsammelson]

@aeharding This is back to being ready to merge.

[rsammelson]

@aeharding, sorry for the pings, but are you ready for this PR if I fix merge conflicts, or do you want to wait?

[rsammelson]

@aeharding I don't think this depends on anything else now, and I have it working with the image gallery share button too.

[aeharding]

I'll take a look soon. To be honest, I'm skeptical we need to prompt the user to ask them what they would like to share 🤔 but I will try it out before any really feedback :)

[rsammelson]

Oh, I like being able to share content or the post

[aeharding]

Oh, I like being able to share content or the post

Was this a feature in Apollo? I know there was the ability to share a picture of the post, but that would be a separate feature.

[rsammelson]

I'm not sure, I never used Apollo. I just want to be able to share the post itself with people so they can interact with it (comment/vote). The app I used had a similar feature.

I assume most people aren't sharing often enough to be bothered by a two option popup when they click share, but I could add a setting to always default to sharing the media link if you want. I would really like to get this one merged so I can use it easily.

[Penagwin]

Here's a screenshot of the context menu from Apollo - I don't remember if anything was below report.

@aeharding Do you want to combine all of the sharing and saving related meta-discussion with #69? There's a several related moving parts with them.

[rsammelson]

In a future PR, I could add more share options to the modal created here to at least allow non-iOS users to be able to share media directly and also a share as image option. Personally I think it would be a better user experience if they only show up when clicking share, the post actions menu is already very long, and it standardizes the experience between using the share button and post actions (and I can add share as a swipe action with the same component along with customizable swipes).

[Penagwin]

What I'm wondering is if we replace the "tap-hold" that iOS 16 users have with just this screen. Then it would be consistent across all platforms?

[rsammelson]

Since tap and hold is a often available OS-level thing, I think leaving it is best to match other iOS apps. But I don't feel strongly about that.

[rsammelson]

@aeharding I added share as a swipe option and updated from the latest main.

[aeharding]

Thanks. I still need time to look at this

[aeharding]

Thanks for the PR! I am closing this because it has become quite stale. Additionally, there is now an option to share the post image from the media viewer :)