Add the ability to configure swipe gestures #497

rsammelson · 2023-07-20T05:16:24Z

Fixes #64

rsammelson · 2023-07-21T00:31:46Z

@aeharding can you take a look at this and let me know your initial thoughts?

aeharding · 2023-07-21T01:16:23Z

Just a cursory glance at the code, looks good from a high level. I won't be able to review until this weekend though. Thanks!

(Sorry, accidentally tapped ready for review)

rsammelson · 2023-07-21T01:24:09Z

Thanks!

aeharding · 2023-07-22T22:49:08Z

Okay, so I just had some time to check this out. A couple thoughts on the UI:

Let's remove the "none" option from each and replace with a slider to disable left and right sliding options (see second picture) (This will require DB changes)
Change the terminology for each option to be consistent with Apollo (and sort order of the options)
Add an icon to each option in the popup (see third picture)
Ideally we would have a swipe icons, but I realize this requires expertise with SVGs so it can be a future thing.

rsammelson · 2023-07-22T22:59:37Z

1. Let's remove the "none" option from each and replace with a slider to disable left and right sliding options (see second picture) (This will require DB changes)

With the none option you can disable only short or long swipes, allowing you to have a single action for each direction at either the short or long swipe trigger point. This would be useful for people who want a couple of swipe actions (perhaps upvote and downvote) but want to make it harder to accidentally trigger them (by only using long swipes). While it takes a little more effort to disable swipes (I can add a disable all option if you want), it allows for a lot more configurability.

2. Change the terminology for each option to be consistent with Apollo (and sort order of the options)

3. Add an icon to each option in the popup (see third picture)

I will fix these soon.

aeharding · 2023-07-23T00:09:00Z

With the none option you can disable only short or long swipes, allowing you to have a single action for each direction at either the short or long swipe trigger point. This would be useful for people who want a couple of swipe actions (perhaps upvote and downvote) but want to make it harder to accidentally trigger them (by only using long swipes). While it takes a little more effort to disable swipes (I can add a disable all option if you want), it allows for a lot more configurability.

That's what the "long swipe trigger point" option does (see second screen shot)

rsammelson · 2023-07-23T00:29:16Z

How does that option work? I don't understand which swipes it disables.

aeharding · 2023-07-23T01:13:55Z

It doesn't disable any option, it just requires you to swipe further before changing to the second swipe option

rsammelson · 2023-07-23T01:20:32Z

My point was that by changing individual things to None, you can set a single action for either direction, and you can choose whether you want it at the short swipe or long swipe distance. I for one would prefer not having a short swipe on comments because I accidentally trigger it sometimes, especially on the left when trying to go back.

aeharding · 2023-07-23T01:57:04Z

I understand, however I'd rather add an option to disable short swipe left universally. Otherwise you could have inconsistent behavior on inbox items vs posts vs comments.

rsammelson · 2023-07-23T02:29:42Z

Thoughts on this look?

aeharding · 2023-07-23T02:32:01Z

Looks great!

rsammelson · 2023-07-23T04:00:39Z

I added icons to the lists:

I also added options to turn off left and right completely:

rsammelson · 2023-07-23T04:14:10Z

Future work is allowing users to disable the back gesture on iOS. Note, I did leave none as an option so far, because I would really like to have that choice; given that it's in a pretty deep menu I imagine it won't bother anyone who doesn't choose it.

src/services/db.ts

src/features/shared/sliding/BaseSlidingVote.tsx

src/features/shared/sliding/SlidingItem.tsx

aeharding · 2023-07-23T05:22:08Z

src/services/db.ts

   */
-  Total: "total",


Was this a bad merge?

No, I realized the sorting was strange, not its least verbose -> most verbose when you look top to bottom.

I'm not sure I understand, to me it makes sense to have default be at the top in general.

I mean that now it's in the order: no information (none) -> some information (only the total) -> all information (separate scores). The default is the middle, and you can choose go up or down a level to see less or more. I can change it if you want.

Let's revert this for now.

src/features/shared/sliding/BaseSlidingVote.tsx

src/features/settings/gestures/swipe_long.svg

src/features/settings/gestures/gesturesSlice.tsx

src/features/inbox/inboxSlice.ts

src/pages/settings/SettingsPage.tsx

aeharding · 2023-07-23T05:38:16Z

I'm experiencing some strange behavior:

Open home feed
Go to gestures page
Turn on "disable swipe gestures" both left and right, then turn both off
Go back to feed, try to swipe item
See the swipe item (upvote, reply etc) stays transparent and doesn't fully enable. You also can't swipe to far action
If you let go and swipe again, the next one should work

Can you replicate? It's not a huge bug or anything just strange behabior

aeharding · 2023-07-23T05:44:40Z

I'm wondering if we should change hide post to bookmark as the default far right swipe item. That would match Apollo and also would avoid confusing new users when they accidentally swipe away a post and lose it. What do you think?

rsammelson · 2023-07-23T06:29:13Z

There's still more to be done, but I wanted to push most of what I have.

src/features/shared/sliding/SlidingItem.tsx

src/services/db.ts

src/features/shared/sliding/BaseSlidingVote.tsx

aeharding · 2023-07-23T15:52:57Z

What do you think about this?

--- a/src/features/settings/gestures/SwipeSettings.tsx
+++ b/src/features/settings/gestures/SwipeSettings.tsx
@@ -145,6 +145,7 @@ export default function SwipeSettings() {
 }

 const swipeIcons = {
+  [OSwipeActionAll.None]: " ",
   [OSwipeActionAll.Upvote]: arrowUpOutline,
   [OSwipeActionAll.Downvote]: arrowDownOutline,
   [OSwipeActionAll.Reply]: arrowUndoOutline,

aeharding · 2023-07-23T15:53:33Z

Can we move Upvote above Downvote in the Setting Selector?

rsammelson · 2023-07-23T16:10:45Z

Can we move Upvote above Downvote in the Setting Selector?

It should already be like that, see the diff from my force push last night https://github.com/aeharding/voyager/compare/553969f2b5245bdab822ee36d4a0d444c20080e4..bef18183ce489791ad9350d9fb60968e1d6669d4. Is it not for you?

rsammelson · 2023-07-23T16:40:31Z

About the bug you mentioned, I can replicate it but I have not been able to figure out why it happens. ~~It actually seems to happen even if you only turn one on and off, and then swipe in that direction.~~ Never mind it only happens when both turn off.

rsammelson · 2023-07-23T17:08:47Z

@aeharding can you take a look at #202? I would like to add share as a swipe option. Otherwise if this gets merged first I can add making it a swipe option to that PR.

aeharding · 2023-07-23T20:10:06Z

@aeharding can you take a look at #202? I would like to add share as a swipe option. Otherwise if this gets merged first I can add making it a swipe option to that PR.

Let's do share in a separate PR so this PR isn't blocked

src/features/settings/gestures/gesturesSlice.tsx

src/features/shared/sliding/SlidingItem.tsx

Change to centralized sliding item action creation based on a dictionary passed into BaseSlidingVote.

- Add swipe icons to show what each setting means - Add icons on swipe menu options - Add switches to completely turn off direction in one shot

rsammelson · 2023-07-23T21:01:04Z

Most recent push was to update to the latest main, I wanted to ensure there were no problems from 9154e0c since it sounded like it might touch something related to this.

aeharding · 2023-07-23T21:56:18Z

I'm still a bit concerned about perf, but I haven't been able to get any conclusive results on perf changes between this and main.

@rsammelson Can you change the default far right swipe for posts from hide post to bookmark? I think this is getting pretty close now.

src/store.tsx

src/features/settings/gestures/SwipeSettings.tsx

aeharding

Nice work, this is quite the enhancement.

rsammelson · 2023-07-24T04:43:25Z

Thanks!

rsammelson mentioned this pull request Jul 20, 2023

enable_downvotes support #499

Merged

aeharding marked this pull request as ready for review July 21, 2023 01:16

aeharding marked this pull request as draft July 21, 2023 01:22

rsammelson force-pushed the configure-swipe branch 2 times, most recently from 6e76902 to 99ee634 Compare July 21, 2023 01:26

rsammelson marked this pull request as ready for review July 23, 2023 04:10

aeharding reviewed Jul 23, 2023

View reviewed changes

src/pages/settings/SettingsPage.tsx Outdated Show resolved Hide resolved

rsammelson marked this pull request as draft July 23, 2023 06:29

rsammelson force-pushed the configure-swipe branch from 553969f to bef1818 Compare July 23, 2023 06:32

aeharding reviewed Jul 23, 2023

View reviewed changes

src/features/shared/sliding/SlidingItem.tsx Show resolved Hide resolved

aeharding reviewed Jul 23, 2023

View reviewed changes

src/services/db.ts Outdated Show resolved Hide resolved

aeharding reviewed Jul 23, 2023

View reviewed changes

src/features/shared/sliding/BaseSlidingVote.tsx Outdated Show resolved Hide resolved

aeharding reviewed Jul 23, 2023

View reviewed changes

src/features/settings/gestures/gesturesSlice.tsx Outdated Show resolved Hide resolved

src/features/shared/sliding/SlidingItem.tsx Outdated Show resolved Hide resolved

rsammelson force-pushed the configure-swipe branch from 6b6c726 to 4595c7a Compare July 23, 2023 20:47

rsammelson marked this pull request as ready for review July 23, 2023 20:48

rsammelson requested a review from aeharding July 23, 2023 20:48

rsammelson force-pushed the configure-swipe branch from 4595c7a to 03d4213 Compare July 23, 2023 20:56

rsammelson added 7 commits July 23, 2023 16:58

Add setings page for gestures

a3527ea

Add reset gestures

3aef621

Refactor to prepare for using settings for swiping

64b5336

Change to centralized sliding item action creation based on a dictionary passed into BaseSlidingVote.

Get configurable gestures mostly working

5f9f3ca

Disable swipe when there are no actions

87488e5

Various improvements

61d4760

- Add swipe icons to show what each setting means - Add icons on swipe menu options - Add switches to completely turn off direction in one shot

Fixes from review

c514978

rsammelson force-pushed the configure-swipe branch from 03d4213 to 1df1fdf Compare July 23, 2023 20:59

rsammelson force-pushed the configure-swipe branch from 1df1fdf to e029ffe Compare July 23, 2023 21:59

aeharding reviewed Jul 23, 2023

View reviewed changes

src/store.tsx Outdated Show resolved Hide resolved

aeharding reviewed Jul 24, 2023

View reviewed changes

src/features/settings/gestures/SwipeSettings.tsx Outdated Show resolved Hide resolved

More fixes from review

c0cae62

rsammelson force-pushed the configure-swipe branch from e029ffe to c0cae62 Compare July 24, 2023 02:40

Change swipe SVG filename conventions

8f55bc3

aeharding approved these changes Jul 24, 2023

View reviewed changes

aeharding merged commit f353596 into aeharding:main Jul 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the ability to configure swipe gestures #497

Add the ability to configure swipe gestures #497

rsammelson commented Jul 20, 2023 •

edited

Loading

rsammelson commented Jul 21, 2023

aeharding commented Jul 21, 2023 •

edited

Loading

rsammelson commented Jul 21, 2023

aeharding commented Jul 22, 2023

rsammelson commented Jul 22, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023 •

edited

Loading

rsammelson commented Jul 23, 2023

aeharding Jul 23, 2023

rsammelson Jul 23, 2023

aeharding Jul 23, 2023

rsammelson Jul 23, 2023

aeharding Jul 23, 2023 •

edited

Loading

aeharding commented Jul 23, 2023 •

edited

Loading

aeharding commented Jul 23, 2023 •

edited

Loading

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

rsammelson commented Jul 23, 2023 •

edited

Loading

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

aeharding left a comment

rsammelson commented Jul 24, 2023

Add the ability to configure swipe gestures #497

Add the ability to configure swipe gestures #497

Conversation

rsammelson commented Jul 20, 2023 • edited Loading

rsammelson commented Jul 21, 2023

aeharding commented Jul 21, 2023 • edited Loading

rsammelson commented Jul 21, 2023

aeharding commented Jul 22, 2023

rsammelson commented Jul 22, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023 • edited Loading

rsammelson commented Jul 23, 2023

aeharding Jul 23, 2023

Choose a reason for hiding this comment

rsammelson Jul 23, 2023

Choose a reason for hiding this comment

aeharding Jul 23, 2023

Choose a reason for hiding this comment

rsammelson Jul 23, 2023

Choose a reason for hiding this comment

aeharding Jul 23, 2023 • edited Loading

Choose a reason for hiding this comment

aeharding commented Jul 23, 2023 • edited Loading

aeharding commented Jul 23, 2023 • edited Loading

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

rsammelson commented Jul 23, 2023 • edited Loading

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

rsammelson commented Jul 23, 2023

aeharding commented Jul 23, 2023

aeharding left a comment

Choose a reason for hiding this comment

rsammelson commented Jul 24, 2023

rsammelson commented Jul 20, 2023 •

edited

Loading

aeharding commented Jul 21, 2023 •

edited

Loading

rsammelson commented Jul 23, 2023 •

edited

Loading

aeharding Jul 23, 2023 •

edited

Loading

aeharding commented Jul 23, 2023 •

edited

Loading

aeharding commented Jul 23, 2023 •

edited

Loading

rsammelson commented Jul 23, 2023 •

edited

Loading