Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast messages should not appear over tab bar #147

Closed
aeharding opened this issue Jul 1, 2023 · 1 comment · Fixed by #764
Closed

Toast messages should not appear over tab bar #147

aeharding opened this issue Jul 1, 2023 · 1 comment · Fixed by #764
Assignees
Labels

Comments

@aeharding
Copy link
Owner

aeharding commented Jul 1, 2023

In Apollo, toast messages come up from below the tab bar and move up to appear right above it, instead of on top of it in wefwef (which is super annoying since you cannot dismiss).

This will likely require some CSS ionic hacking to change what a toast considers the bottom of the page, along with z-index hacking.

But this is absolutely a quality of life thing. :)

Anyone is welcome to take a shot at this.

Bonus points for making an ionic feature request (or finding one) to swipe away toast messages

@aeharding aeharding added enhancement New feature or request parity:apollo labels Jul 1, 2023
@aeharding aeharding added this to the v1 milestone Jul 1, 2023
@rsammelson
Copy link
Contributor

rsammelson commented Jul 3, 2023

See ionic-team/ionic-framework#21769, it looks like a PR to add swipable toasts has been languishing for a couple years.

I'll work on this next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants