Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Copy Link" action in the share sheet #426

Closed
wants to merge 2 commits into from

Conversation

sharunkumar
Copy link
Contributor

@sharunkumar sharunkumar commented Jul 14, 2023

image

@rsammelson
Copy link
Contributor

This could also be moved to the share menu I'm adding in #202

@sharunkumar
Copy link
Contributor Author

sharunkumar commented Jul 14, 2023

This could also be moved to the share menu I'm adding in #202

Hey yeah I guess I can contribute to it. Though, your branch seems like it needs to be rebased to the latest version?
Lemme know how I can add my commit to it

Update: it looks like the branch can be rebased without any conflicts: https://github.com/sharunkumar/voyager/commits/share-improvements

@rsammelson
Copy link
Contributor

Yeah that was more a, "if that gets merged." Right now the main post action sheet is almost full, and @aeharding mentioned before he wanted to avoid adding things to it I think.

@sharunkumar
Copy link
Contributor Author

Right now the main post action sheet is almost full

if that's the case, I feel like the upvote and downvote actions can be removed from the share sheet, because they're already available as buttons 🤔

@rsammelson
Copy link
Contributor

See #417

@aeharding aeharding force-pushed the main branch 2 times, most recently from 4346eb6 to 86d9319 Compare August 5, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants