Move view site button next to site title #51852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paaljoachim
approved these changes
Jun 23, 2023
|
Size Change: +11 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
Thanks @paaljoachim! Let's hold on a merge for a bit though; I would like to get additional feedback before pushing it in. |
|
Yep, that makes sense to me, though if we do this I'd reduce the size of the icon similar to how we do in other places. You can even underline the title to indicate it's a link: 
I think the only open question we need to answer is: do we eventually expect site logo + site title to be one big clickable area to go back to the top level admin? If yes, then this would probably not be a good change. If we expect it to always be only the site logo/icon, then this change is fine. I lean towards this assessment myself. |
|
In the latest Gutenberg, View Site link is always visible and the position has been adjusted slightly. Is this PR still valid for the current Gutenberg trunk? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Can work. Not sure it's better, the big external link icon feels like an icon button that should sit on the right next to other icon buttons. Separately, I have a feeling lots of sites "in the wild" have very long titles. In fact trunk at the moment doesn't handle this too well:
It's possible MacRumors uses the tagline to contextually show the verbose description, but the possibility of very long titles remains. How this is handled is something good to consider. Would the external link bump up against the loupe and stay put, causing the title to wrap from that point on? Would the text be elided? If the need is to free up that space for another icon button, another option is this. Resting state:
Hover state:
That would change the icon button to a glyph and feel part of the title instead. |
|
I'd echo Joen; it seems sensible to do one or the other:
Iirc, when this was initially implemented the argument against making the title a link was; it might end up feeling like a label for the site icon button, and that the two elements having different behaviours could be unexpected. I don't have a strong feeling about that personally, but wanted to raise it as a valid concern. Separate hover effects for each could help mitigate any confusion there. |
#60885 was submitted to display a fallback URL when the site title does not exist. Once this is merged, the site title text is guaranteed to always be visible, so the above approach should be fine. |
|
We have this in the admin bar today. I think we can do the same in the Site Editor (sans home icon), using the site name as the link and showing the glyph on hover.
|
|
@jasmussen What do you think of this? CleanShot.2024-04-30.at.13.28.27.mp4 |
|
I spun up #61258 to explore as this effort is quite old. |
I think that can work. |
|
I'll close this in favor of #61258 then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
An alternative at the placement of the external link within the site hub.
Other follow-ups could be to make the site title a link itself, and perhaps reduce the externalLink icon to only show up when hovering the site title itself.
Testing Instructions
Screenshots or screencast
Before:
CleanShot.2023-06-23.at.09.57.24.mp4
After:
CleanShot.2023-06-23.at.09.53.55.mp4