Add: View button to the post card panel. #60705
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +125 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
abc20f2 to
45b527d
Compare
ntsekouras
reviewed
Apr 16, 2024
| label={ action.label } | ||
| icon={ action.icon } | ||
| isDestructive={ action.isDestructive } | ||
| size="compact" |
There was a problem hiding this comment.
You'll need to update the size to small to match the designs. With this change you don't need the css changes you made here, so you can remove them.
ntsekouras
reviewed
Apr 16, 2024
| ! [ | ||
| TEMPLATE_POST_TYPE, | ||
| TEMPLATE_PART_POST_TYPE, | ||
| PATTERN_POST_TYPE, |
There was a problem hiding this comment.
wp_navigation is missing.
|
Should we remove the similar button in post editor with this addition? --cc @WordPress/gutenberg-design |
ntsekouras
reviewed
Apr 16, 2024
| isDestructive={ action.isDestructive } | ||
| size="compact" | ||
| onClick={ async () => { | ||
| await action.callback( [ item ] ); |
There was a problem hiding this comment.
We don't need to await anything here.. We can just call the action.callback.
ntsekouras
reviewed
Apr 16, 2024
| @@ -100,6 +122,7 @@ export default function PostCardPanel( { className, actions } ) { | |||
| > | |||
| { title ? decodeEntities( title ) : __( 'No Title' ) } | |||
| </Text> | |||
| <ActionTrigger item={ post } action={ viewPostAction } /> | |||
There was a problem hiding this comment.
I think the end goal is to unify the actions and handle them holistically. Since we don't do that yet and consumers can also pass other actions, I think it makes more sense to rename ActionTrigger to ViewPostLink or something similar for now.
Good eye! I don't recall the issue where it was discussed adding that link, but I do remember that top toolbar addition being an important one as far as prominence, so I wouldn't remove it in the top toolbar. The redundancy of also having it in the panel is a good callout, though; it definitely exists there to afford the presence when the same panel shows in the Data View context in the future. But perhaps we should adopt this pattern for the panel? I'll defer to @jameskoster. |
|
That button doesn't exist in the site editor. We should decide whether it should or not. A consideration is that it would need to be disabled when you're viewing a template which might be a bit awkward? We also have this affordance which adapts contextually based on what you're editing: 
Personally I think the 'View' link in the Inspector is useful in the site editor context as it provides single-click access to the frontend. It also seems appropriately placed given the nuance outlined above. |
Overall an argument for a light-weight inclusion in the inspector panel. Could just link to the homepage if on a template. |
|
Yup, if we want to include that button in the site editor too, then we don't need the same button so prominent in the Inspector. An item in the ellipsis menu seems adequate: 
|
45b527d to
7342f5a
Compare
|
Hi @jasmussen, @jameskoster, so just to confirm we stop the addition of the view button to the postcard panel (leaving it in ellipsis as it is now) and we add the top toolbar view button at the side of save in edit site to match what edit post already has. Is that right? |
Yup.
I'll defer to Joen on that but will say; If we do add it in the top bar then we should probably remove it from the Device menu at the same time, this one: 
It would be a bit duplicative to have it in both places. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #59689.
Adds a view button to the PostCardPanel. It appears in both edit post and edit site. When clicked opens the post link in a new window.
Testing Instructions
Opened a page on the side editor and verified the view button works as expected.
Repeated the test for the post editor.
Testing Instructions for Keyboard