Make the site hub View Site link always visible. #57423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -65 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
|
I was not able to use the resizer to make the navigation panel narrower, when I tried, I was redirected to the editor, I think my screen size may be too small. Other than that the change works well for me. With mouse, in Chrome on mac: With keyboard, in Firefox on mac, with tabbing enabled in the browser settings: |
SergeyBiryukov
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57421
What?
Makes the site hub View Site link always visible instead of showing it only on hover or focus.
Why?
Interactive controls that appear and disappear are always a problem for general usability and accessibility.
Revealing the View Site link only on hover and focus appears to have the side effect of making the functionality less disoverable.
How?
Makes the View Site link always visible, Make it behave like the Command Center toggle when resizing the editor canvas.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast