Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Needs a fallback title when the Site Title is empty. #60765

Closed
t-hamano opened this issue Apr 16, 2024 · 0 comments · Fixed by #60885
Closed

Site Editor: Needs a fallback title when the Site Title is empty. #60765

t-hamano opened this issue Apr 16, 2024 · 0 comments · Fixed by #60885
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

Description

Discovered this while looking at #51852.

The dashboard displays the site URL with the protocol and www removed as a fallback if the site title is empty.

dashboard-site-title

On the other hand, the Site Editor shows nothing.

image

This is especially problematic if the site title itself is changed to a link, as explored in #51852.

Similar to dashboards, I think we need a fallback title.

Step-by-step reproduction instructions

  • Empty title on General Settings page.
  • Access the Site Editor.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 16, 2024
@t-hamano t-hamano changed the title Site Editor: Needs a fallback title when Saito Taitoru is empty. Site Editor: Needs a fallback title when the Site Title is empty. Apr 16, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants