Prepare for OPA 1.0 #1317
Merged
Prepare for OPA 1.0 #1317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlieegan3
reviewed
Jan 7, 2025
charlieegan3
approved these changes
Jan 7, 2025
| rego-version: 1 | ||
| ``` | ||
|
|
||
| Additionally, Regal will scan the project for any `.manifest` files, and user any `rego_version` found in the manifest |
There was a problem hiding this comment.
Suggested change
| Additionally, Regal will scan the project for any `.manifest` files, and user any `rego_version` found in the manifest | |
| Additionally, Regal will scan the project for any `.manifest` files, and use any `rego_version` found in the manifest |
There was a problem hiding this comment.
Should this part also mention the _0.rego suffix?
|
|
||
| mod, err = ast.ParseModuleWithOpts(filename, policy, opts) | ||
| if err == nil { | ||
| if hasRegoV1Import(mod.Imports) { |
There was a problem hiding this comment.
what about future keywords? do we also need to handle these here?
There was a problem hiding this comment.
That's still Rego v0 AFAICS.. i.e. you can import contains without using it, while you can't import rego.v1 without using contains, etc.
| var versionsMap map[string]ast.RegoVersion | ||
|
|
||
| // TODO: How should we deal with this in the language server? | ||
| // AllRegoVersions will call WalkDir on the root to find manifests, but that's obviously not |
There was a problem hiding this comment.
Hmm, I guess we can do something at start up and when new files are found. We do this for ignored files, finding new ones, caching their builtins etc so maybe something like that makes the most sense here?
There was a problem hiding this comment.
I suppose this is address by now, right?
charlieegan3
reviewed
Jan 8, 2025
Go: - Use OPA v1 packages - Add function to parse Rego of unknown version - Allow providing the Rego version via config or .manifest files - Make `regal fix` formatter consider version to format for Rego: - Remove `import rego.v1` (via `opa fmt`) - Add `config.capabilities.is_opa_v1` - Use that to disable `use-if`, `use-contains`, `use-rego-v1` - Update tests for 1.0 compliance Docs: - TODO remove `import rego.v1` from all examples - `regal fix` doesn't work well - Many failing e2e tests, despite some effort - Test LSP functionality Signed-off-by: Anders Eknert <anders@styra.com>
* fixer: Prep for 1.0 tests Signed-off-by: Charlie Egan <charlie@styra.com> * fixer/fmt: Add tests for other rego versions Signed-off-by: Charlie Egan <charlie@styra.com> * fixer: Update fixer e2e test Signed-off-by: Charlie Egan <charlie@styra.com> * Correct formatting of launch.json * fixer: Return formatting to Fixer test Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Mainly, this is ensuring the configs for each test are correct. Signed-off-by: Charlie Egan <charlie@styra.com>
Signed-off-by: Charlie Egan <charlie@styra.com>
* lsp/server: Cache AllRegoVersions at config load This does not reload when a .manifest file is changed yet. Signed-off-by: Charlie Egan <charlie@styra.com> * concurrent/map: Nil map is empty Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Also, use new version cache to determine version for formatting Signed-off-by: Charlie Egan <charlie@styra.com>
- Remove `import rego.v1` from examples - Add new page covering Regal and OPA 1.0 - Update logic of any rules obsolete in 1.0 to make sure they're automatically disabled when 1.0 is targeted, and continue to work when older versions are linted - Update a few tests to remove `import rego.v1` - Many minor fixes related to this theme Signed-off-by: Anders Eknert <anders@styra.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go:
regal fixformatter consider version to format forRego:
import rego.v1(viaopa fmt)config.capabilities.is_opa_v1use-if,use-contains,use-rego-v1Docs:
import rego.v1from all examplesregal fixdoesn't work well