golangci-lint: Update and address linter issues #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Jan 8, 2025
| @@ -773,7 +773,7 @@ func BenchmarkRegalLintingItself(b *testing.B) { | |||
|
|
|||
| var rep report.Report | |||
|
|
|||
| for i := 0; i < b.N; i++ { | |||
| for range b.N { | |||
There was a problem hiding this comment.
This doesn't work in Go 1.22 which is what we target.. but I guess since these are test files, it doesn't matter.
There was a problem hiding this comment.
Hmm, I wonder why golangcilint wasn't able to work that out? perhaps because we have a more recent toolchain version?
There was a problem hiding this comment.
Yeah, that sounds reasonable, and smart :) If it did this generally, we'd have a lot of places to update I reckon.
anderseknert
pushed a commit
that referenced
this pull request
Jan 8, 2025
Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
that referenced
this pull request
Jan 9, 2025
Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
pushed a commit
that referenced
this pull request
Jan 13, 2025
Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses linter issues found in #1321