lsp/server: Cache AllRegoVersions at config load #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not reload when a .manifest file is changed yet. Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Jan 9, 2025
| loadedConfigEnabledNonAggregateRules []string | ||
| loadedConfigEnabledAggregateRules []string | ||
| loadedConfigAllRegoVersions *concurrent.Map[string, ast.RegoVersion] |
internal/lsp/server.go
Outdated
| var versionedDirs []string | ||
|
|
||
| // if we have no information, then we can return the default | ||
| if l.loadedConfigAllRegoVersions == nil || l.loadedConfigAllRegoVersions.Len() == 0 { |
There was a problem hiding this comment.
Perhaps we should have Len() always return 0 when its parent is nil? It would make the check here a little cleaner.
| return fmt.Sprintf("package %s\n\nimport rego.v1\n", pkg), nil | ||
| } | ||
|
|
||
| return fmt.Sprintf("package %s\n\n", pkg), nil |
Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
pushed a commit
that referenced
this pull request
Jan 9, 2025
* lsp/server: Cache AllRegoVersions at config load This does not reload when a .manifest file is changed yet. Signed-off-by: Charlie Egan <charlie@styra.com> * concurrent/map: Nil map is empty Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
pushed a commit
that referenced
this pull request
Jan 13, 2025
* lsp/server: Cache AllRegoVersions at config load This does not reload when a .manifest file is changed yet. Signed-off-by: Charlie Egan <charlie@styra.com> * concurrent/map: Nil map is empty Signed-off-by: Charlie Egan <charlie@styra.com> --------- Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not reload when a .manifest file is changed yet.