lsp/completions: No rego.v1 import when in v1 file #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, use new version cache to determine version for formatting Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
approved these changes
Jan 9, 2025
| @@ -11,6 +11,7 @@ import data.regal.lsp.completion.location | |||
| # description: completion suggestion for rego.v1 | |||
| items contains item if { | |||
| not strings.any_prefix_match(input.regal.file.lines, "import rego.v1") | |||
| not input.regal.context.rego_version == 3 # the rego.v1 import is not used in v1 rego | |||
There was a problem hiding this comment.
I'd put this first as it's the cheaper check.. but no big deal.
|
|
||
| # METADATA | ||
| # description: same as input_with_location but with option to set rego_version too | ||
| input_with_location_and_version(policy, location, rego_version) := {"regal": { |
anderseknert
pushed a commit
that referenced
this pull request
Jan 9, 2025
Also, use new version cache to determine version for formatting Signed-off-by: Charlie Egan <charlie@styra.com>
anderseknert
pushed a commit
that referenced
this pull request
Jan 13, 2025
Also, use new version cache to determine version for formatting Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 14, 2025
StyraInc#1327 (comment) Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
to charlieegan3/regal
that referenced
this pull request
Jan 14, 2025
StyraInc#1327 (comment) Signed-off-by: Charlie Egan <charlie@styra.com>
charlieegan3
added a commit
that referenced
this pull request
Jan 14, 2025
#1327 (comment) Signed-off-by: Charlie Egan <charlie@styra.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, use new version cache to determine version for formatting