Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v24.10.2 #1520

Merged
merged 36 commits into from
Oct 19, 2024
Merged

v24.10.2 #1520

merged 36 commits into from
Oct 19, 2024

Conversation

lakikowolfe
Copy link
Contributor

jaymedina and others added 30 commits September 24, 2024 15:48
@jaymedina
initial edits
2840c66
@jaymedina
Restructure: Moving things under contribution guidelines
693e473
@jaymedina
Update README.md
95eef66
@jaymedina
Small restructure for devs and usage cases
2f7e97d
@jaymedina
Update instructions for making .synapseConfig file
2f7327c
@jaymedina
Update Google credentials section
4b155a1
@jaymedina
Remove step 6 from contributor installation
8624b47
@jaymedina
Remove tests/ hyperlink
2a22f54
@jaymedina
Fix link to CLI docs
8e8cd41
@jaymedina
Point users to service desk
8a49820
@jaymedina
Update code style section with how to run black
5cd91dd
@jaymedina
mention pre-commit in code style isntead
3ee58ad
@jaymedina
Revisit Set up configuration files
023bb0a
@jaymedina
.synapseCache
90930cd
@jaymedina
.synapseConfig location
b1cb1de
@jaymedina
Update README.md
5751505
@jaymedina
Update README.md
d142839
@jaymedina
second pass through developer instructions
95b68ce
@jaymedina
Update README.md
5c9ecfe
@jaymedina
update Docker Usage section
f2e7661
@jaymedina
Update contribution guideline
c4f9fcc
@jaymedina
tldr
2c8c72a
@jaymedina
address comments from FDS-1172
ce06422
@jaymedina
Update README.md
6c4193c
@jaymedina
Consolidate confluence docs
e12d7eb
@jaymedina
Update table of contents
eec2c88
@jaymedina
Update README.md
18e1549
@BryanFauble
[FDS-2502] Walk back up directory tree to get location in project (#1518
954aa54 
)

* Walk back up directory tree to get location in project
@BryanFauble
[FDS-2497] Wrap google API execute calls with a 5 attempt retry (#1513)
49c701c 
* Wrap google API execute calls with a 5 attempt retry
@jaymedina
Consolidated CONTRIBUTION.md and contributing guidelines in the README
c3d4552
@andrewelamb
Copy link
Contributor

How is develop out-of-date with the main branch?

@lakikowolfe
Copy link
Contributor Author

@andrewelamb are you asking me? I'm not sure

@andrewelamb
Copy link
Contributor

Asking anyone :)

@lakikowolfe
Copy link
Contributor Author

@andrewelamb should I wait on a response to update the branch?

@thomasyu888
Copy link
Member

thomasyu888 commented Oct 17, 2024 •
edited
Loading

Asking anyone :)

@andrewelamb

This happens sometimes when you make a PR into main from develop. I've seen that sometimes you have to merge main back into develop for some reason... see screenshot
image

@andrewelamb
Copy link
Contributor

Thanks @thomasyu888 , @lakikowolfe if you could merge main into develop first that would be great. It looks like you can do it with the update branch button.

@andrewelamb
Copy link
Contributor

@lakikowolfe Go ahead and merge. The tests that are faailign all pass loccally for several individuals who've ran them.

@andrewelamb andrewelamb self-requested a review October 18, 2024 18:15
@andrewelamb
Copy link
Contributor

@lakikowolfe Hold for now @jaymedina Is trying the tests one mroe time, while nothing else is running

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@lakikowolfe lakikowolfe merged commit d68f624 into main Oct 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiaJordan GiaJordan Awaiting requested review from GiaJordan

@linglp linglp Awaiting requested review from linglp

@andrewelamb andrewelamb Awaiting requested review from andrewelamb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lakikowolfe @andrewelamb @thomasyu888 @jaymedina @BryanFauble @linglp