Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FDS-2218] Update the README #1510

Merged
merged 32 commits into from
Oct 17, 2024
Merged

[FDS-2218] Update the README #1510

merged 32 commits into from
Oct 17, 2024

Conversation

jaymedina
Copy link
Contributor

@jaymedina jaymedina commented Sep 24, 2024

problem

The README.md needed to be updated for clarity in certain parts, particularly the installation instructions and use-case examples.

solution

  • Overall re-structure and stylistic changes
  • Add a TL;DR section to provide a quick summary of schematic and its uses
  • Improve developer setup and contribution instructions

Items from Jira tickets:

  • Update development environment instructions for a wider audience: ticket
  • Consolidate installation instructions between Confluence and GitHub: ticket
  • Point readers to service desk for help: ticket
  • Fix hyperlink in Testing section: ticket
  • Fix CLI reference link: ticket

testing

N/A

@jaymedina jaymedina marked this pull request as ready for review October 4, 2024 20:45
@jaymedina jaymedina requested a review from linglp as a code owner October 4, 2024 20:45
Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Amazing usage of formatting using the note, important, and warning block!

Copy link
Collaborator

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment on a dead link, otherwise LGTM!

@GiaJordan
Copy link
Contributor

@jaymedina thank you so much for your effort on this! I just left a couple of small comments/questions.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@jaymedina jaymedina requested a review from GiaJordan October 16, 2024 22:35
@GiaJordan
Copy link
Contributor

@jaymedina thanks for making those changes!
When I was looking through the README file though it looks like the section links from Contribution Guidelines through Reporting Bugs or feature requests don't lead anywhere now?

@jaymedina
Copy link
Contributor Author

@GiaJordan you're right, that's because I moved those sections out of the README and into CONTRIBUTING - I'll go ahead and remove them from the table of contents. Thanks for the catch!

@GiaJordan
Copy link
Contributor

@jaymedina that makes sense, thanks!

Copy link
Contributor

@GiaJordan GiaJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @jaymedina ! approving before tests finish as changes are constrained to the md doc files

Copy link

@linglp linglp merged commit d6ba62f into develop Oct 17, 2024
7 checks passed
@linglp linglp deleted the develop-fds-2218-update-readme branch October 17, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants