-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FDS-2218] Update the README #1510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Amazing usage of formatting using the note, important, and warning block!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment on a dead link, otherwise LGTM!
@jaymedina thank you so much for your effort on this! I just left a couple of small comments/questions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
@jaymedina thanks for making those changes! |
@GiaJordan you're right, that's because I moved those sections out of the |
@jaymedina that makes sense, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @jaymedina ! approving before tests finish as changes are constrained to the md doc files
|
problem
The
README.md
needed to be updated for clarity in certain parts, particularly the installation instructions and use-case examples.solution
TL;DR
section to provide a quick summary ofschematic
and its usesItems from Jira tickets:
testing
N/A