-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FDS-2502] Walk back up directory tree to get location in project #1518
[FDS-2502] Walk back up directory tree to get location in project #1518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! Not sure if we just wanted to add the test in that branch as well, but going to pre-approve.
@BryanFauble I think one of the tests failed. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. After @GiaJordan review again, feel free to merge. Thanks for your work on this Bryan!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BryanFauble thank you so much for your help with all of this! Looks good to me!
Problem:
Solution:
Testing: