Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FDS-2502] Walk back up directory tree to get location in project #1518

Merged
merged 16 commits into from
Oct 15, 2024

Conversation

BryanFauble
Copy link
Collaborator

@BryanFauble BryanFauble commented Oct 4, 2024

Problem:

  1. When a nested file is used as the datasetId the walk function was only returning back the path where the nested file was located and below. It did not consider where it was in the project if it was in a nested folder.

Solution:

  1. Walk back up the directory tree until we get back to the project, this was we know the prefix of where we started the walk function and can return back the correct location.

Testing:

  1. There is at least 2 integration tests covering this.

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM! Not sure if we just wanted to add the test in that branch as well, but going to pre-approve.

@thomasyu888
Copy link
Member

@BryanFauble I think one of the tests failed.

@BryanFauble BryanFauble requested a review from GiaJordan October 15, 2024 16:44
Copy link

@BryanFauble BryanFauble requested a review from linglp October 15, 2024 18:00
Copy link
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. After @GiaJordan review again, feel free to merge. Thanks for your work on this Bryan!!

Copy link
Contributor

@GiaJordan GiaJordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BryanFauble thank you so much for your help with all of this! Looks good to me!

@BryanFauble BryanFauble merged commit 954aa54 into develop Oct 15, 2024
7 checks passed
@BryanFauble BryanFauble deleted the fds-2502-determine-nested-directory-location branch October 15, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants