Schematic v24.10.1 #1514
Merged
Schematic v24.10.1 #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: call get_node_validation_rules with appropriate parameters when storing annotations
* test single version * remove python version from name * remove feature branch pdoc run * remove quotes
* splits up test_filename_manifest * adds unit tests * updates test_validation * removes commented code * fix test order * revert test_validation changes * revert id * updates filename_validation and testing * removes extra comment * updates tests to txt6 * test python version issue * undo last * redo last * fix pipe * run pytest in line * try poetry shell * removes caching * updates unit tests for dataset_scope * try python version setting * split lines * revert ci test * adds +2 comment * accounts for entityId empty strings * use existing DMGE fixture * corrects val_rule * dummy commit * dummy commit * test without caching * remvoe caching * string version * remove caching * remove test caching * try caching path * remove caching key version * try jenny fix for venv corruption
* update how annotations are accessed * update submission integration test * Remove venv caching --------- Co-authored-by: Jenny Medina <medina.stsci@gmail.com> Co-authored-by: Jenny V Medina <jenny.medina@sagebase.org>
Fix: remove caching poetry dependencies in CI workfows
|
|
I would ignore the SonarCloud Code analysis, but awesome to see the integration tests passed! |
andrewelamb
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schematic pypi release
FDS-2297
Release Scope