Fixes failing pdoc deployment
#1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BWMac this failure of integration test is due to this issue that Bryan is working on: https://sagebionetworks.jira.com/browse/FDS-2240. Since the error is inconsistent, I think you could rerun the workflow to avoid being blocked. But we should definitely work on/prioritize FDS-2240. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #1503 which should have fixed the
pdocdeployment. The problem with the last change was that it created two artifacts with the namesschematic-docs-3.9andschematic-docs-3.10, when thedeploystep expects an artifact calledgithub-pages. The previous fix required an update to the naming because the newer version ofupload-pages-artifactdoes not allow duplicate names. So therefore we now cannot have thebuildpart of the workflow run on both Python 3.9 and 3.10 and also have thedeploystep work properly.This PR adjusts the
buildstep to use only Python 3.10 and then to produce a single artifact calledgithub-pageswhich can then (hopefully) be deployed.Note: It is difficult to test this step in a feature branch because there is a branch protection policy in place preventing that from happening.