-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: remove caching poetry dependencies in CI workfows #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
BWMac
approved these changes
Sep 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Relates to: https://sagebionetworks.jira.com/browse/FDS-2439
For some reasons, virtual environment was not created successfully in this step:
That caused poetry to show the following error:
I can confirm that the virtual env didn't get created successfully because when I did
poetry env info
,Path
variable is showing as empty, andpoetry env info --path
didn't work when I ran that on GH remotely.Since installing dependencies doesn't take that much time anyway, @BWMac, @jaymedina and I decided to remove the capacity of caching dependencies for now.
More context can be found here
Solution
Remove caching when installing dependencies.
Note: in the future, if there's a need to utilize cached dependencies, the documentation here: https://python-poetry.org/docs/configuration/#virtualenvsin-project and also looking at these two commit: 8339da7 and 7fee916 will be helpful.