Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Key combinations doesn't work #8192

Open
ghost opened this issue Feb 19, 2023 · 10 comments · Fixed by #12285
Open

[BUG]: Key combinations doesn't work #8192

ghost opened this issue Feb 19, 2023 · 10 comments · Fixed by #12285

Comments

@ghost
Copy link

ghost commented Feb 19, 2023

Describe the Bug

Trying to use key combinations to trigger gamepad actions (not macros) result in the action being triggered by pressing any of the keys of the combination.

Reproduction Steps

  1. Settings
  2. Controllers
  3. Any controller port(Dualshock 2)
  4. Click any gamepad button on screen to bind a key to it
  5. Press desired key combination
  6. Try the key combination in-game

Expected Behavior

The action should only trigger when you press the whole combination instead of any of its keys.

For example, I set up the combination Shift+W to the Left Analog's UP button, however, the action gets triggered whether I press Shift or W.

image

PCSX2 Revision

v1.7.4110

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

@ghost ghost added the Bug label Feb 19, 2023
@Mrlinkwii Mrlinkwii added the PAD label May 19, 2023
@JordanTheToaster
Copy link
Member

Still an issue on v1.7.4534.

@kamfretoz
Copy link
Contributor

Still an issue as of v1.7.5095.

@bslenul
Copy link
Contributor

bslenul commented Nov 7, 2023

I mentioned it on Discord the other day but forgot to reply here: still an issue with current nightly (1.7.5192 when typing this), I tried to bisect but it looks like it never worked, 1.7.2764 (which is the oldest Qt version available for download on the website) already acts like that. Also noticed that DuckStation has the same issue.

Idk if it matters but I've only tested on Windows 10.

@refractionpcsx2
Copy link
Member

It's weird, cos I have Ctrl+O as a hotkey for making a multi frame GS dump, and that works, but if I try say Ctrl+M for circle, it doesn't :/

@stenzek
Copy link
Contributor

stenzek commented Nov 8, 2023

IIRC it's because the axis event handlers fire an update if any button in the chord is pushed, whereas button handlers will only fire when the overall state changes.

@belarm
Copy link

belarm commented Jan 13, 2025

Still getting this issue

@Glebux
Copy link
Contributor

Glebux commented Feb 7, 2025

Fix this already, it's been almost 2 years

@JordanTheToaster
Copy link
Member

Fix this already, it's been almost 2 years

PRs welcome.

@timbobbl
Copy link

How is this still a problem what

@bslenul
Copy link
Contributor

bslenul commented Mar 2, 2025

This issue should be re-opened, the PR that auto-closed it was about macros, as clarified by the author: #12285 (comment)

@TheLastRar TheLastRar reopened this Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants