Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Macro triggers using logical OR instead of logical AND for multi-button triggers #10398

Closed
RedPanda4552 opened this issue Dec 12, 2023 · 2 comments

Comments

@RedPanda4552
Copy link
Contributor

Describe the Bug

Setting a macro to trigger on multiple keys will cause any of the member keys individually to set off the macro. This affects any macros with 2+ trigger keys involved.

E.g. SDL-0/RightShoulder & SDL-0/B

Pressing SDL-0/RightShoulder, or pressing SDL-0/B will activate the macro.

Instead, both should be pressed to activate the macro.

Reproduction Steps

Set up a macro, hold one button then press and release another to make a multiple key trigger. Pressing either of the two buttons without the other will set off the macro when it shouldn't.

Expected Behavior

Pressing one of but not all members of a macro trigger should not set off the macro. Pressing all members should.

PCSX2 Revision

v1.7.5285

Operating System

Windows 10 (64bit)

If Linux - Specify Distro

No response

Logs & Dumps

No response

@stenzek
Copy link
Contributor

stenzek commented Dec 13, 2023

Duplicate of #8192 - I explained what's going on there (probably not in enough detail).

@RedPanda4552 RedPanda4552 removed their assignment Sep 8, 2024
@RedPanda4552
Copy link
Contributor Author

Closing in favor of #8192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants